-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APPEALS-45267 | Saved Search - Change History | Feature Branch Tracking PR #23096
Open
roberttravispierce
wants to merge
22
commits into
main
Choose a base branch
from
feature/APPEALS-45267
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit 3f361e4 and detected 0 issues on this pull request. View more on Code Climate. |
* first pass at creating blank saved search page * remove unused imports * basic storybook * refactor, add tests, use absolute links * add a probably temporary route to get admin restriction * refactor to make code climate leave me alone * remove unused imports * remove a trailing slash * fix frontend tests and more linter fixes * remove trailing slash in spec * DRY up noncomp store creation * Update client/app/nonComp/pages/SavedSearches.jsx Co-authored-by: Tyler Broyles <[email protected]> * move test into a step * put text into constant, refactor test * Update client/app/nonComp/pages/SavedSearches.jsx Co-authored-by: Brandon Lee Dorner <[email protected]> * delete feature notes and unused code * fix test typo --------- Co-authored-by: Tyler Broyles <[email protected]> Co-authored-by: Brandon Lee Dorner <[email protected]>
* Added new model and spec files * rubocop linting * rubocop fixing linting error * fixing schema file * changes from PR feedback * added add_foreign_key for savedsearch * updated factory attribute names --------- Co-authored-by: Brandon Lee Dorner <[email protected]>
* initial commit before merging dependent ticket - APPEALS-45336 * merge feature branch and fix merges * addressing PR comments * more PR feedbacks * adding MarginLeft --------- Co-authored-by: Brandon Lee Dorner <[email protected]>
# Conflicts: # db/schema.rb
* added controller actions and routes * added action logic * adding index for the controller, modificaiton in the routes and serializer * added spes tests * spec for index, show and controller * fixing the linter and frontend error * serializer spec for saved_search * linter fix * adding show template * renamed saved search factory file * made changes to PR feedback * changed routes setup * fixing the route and pr comments * fixing spec tests and linting errors * linting errors * fixing the failed tests * fixing spec tests * making linter happy * adding id to the serializer --------- Co-authored-by: almorbah <[email protected]> Co-authored-by: Brandon Lee Dorner <[email protected]>
* Initial commit that refactors the decision review queue redux store and react components to properly work without the first page load coming directly from the decision reviews controller index or show actions. * Added a business line information route and a component to retrieve that data if it is not present for the decision review queue to allow redux routing without coming directly from the decision_reviews_controller. * Fixed a couple of failing tests and added the filter details back to the decision review index html file. * Moved the loading check to NonCompTabs instead of TaskTableTabto prevent a bug where the rendering code would still execute even though the loading variable was true. * Updated a failing jest snapshot.
* initial commit with Populate tabs on Saved Searches page * added feature spec tests * fixed feature spec tests * fixing spec tests * addressing PR feedback * addressing PR feedback fixing variable names * addressing PR feedback * linting error
…and SavelimitReachedModal. (#23428) * first commit * meeting AC for APPEALS-45670 - adding contents for savedSearchModal * frontend test and AC fixes * save search mock data * fixing spec failures and adding feature test * fixing linter issues * reverting changes to fix github from running * fixing linter and setting scrollonAlert true * fixing some errors and data * fixing the linter and jest failure * fixing the snap and trying fixing the save_search_spec * fixing bug due to mutation and PR comments * fixing linter and snapshot * fixing the spaces * fixing linter --------- Co-authored-by: Brandon Lee Dorner <[email protected]>
* making delete button work in Saved Searches * jest test * adding more jest testing * Feature test * addressing PR comment * changing the title to Copy.json instead of hard code --------- Co-authored-by: Brandon Lee Dorner <[email protected]>
* making delete button work in Saved Searches * jest test * adding more jest testing * Feature test * addressing PR comment * changing the title to Copy.json instead of hard code * test and stories and meeting the AC * removing duplication from stories and test to make code climate stuff happy * Rename SaveLimitReachModal.stories.js to SaveLimitReachedModal.stories.js renaming the file to match the main file * fixing the slicer and PR comments * removing eslint disable --------- Co-authored-by: Brandon Lee Dorner <[email protected]>
* fixed merge conflict * fixing some edge cases * fixing clear filter * added feature tests * clean up * fixing linitng errors * more liniting erros * update form values * fixing liniting error * eslint disable max-lines * first round of PR comments * PR feedback * removed unused prop * error dropdown message is incorrect fix * saveSearchParams key back to snak case for backend compatibility * Pr feedback changes * change disableBanner to clearStatus * moved const inside Memo * added handleViewSavedSearch to delete SaveLimitReachedModal * added clearStatus to clear filter --------- Co-authored-by: Brandon Lee Dorner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Tracking PR is for APPEALS-45267 Saved Search - Change History feature branch in order to facilitate syncing with master throughout the development cycle.