Leaf 3891 - Remove unused empUID argument #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaoVA
requested review from
Pelentan,
aerinkayne,
pete-nerantzinis,
raphaelfretter,
shaneodd,
AmandaSumner,
maxrichardjr,
jrodcode and
jampaul3
as code owners
jampaul3
changed the title
jampaul3
reviewed
Jul 21, 2023
maxrichardjr
approved these changes
Jul 21, 2023
raphaelfretter
approved these changes
Jul 24, 2023
jrodcode
approved these changes
Jul 25, 2023
2 tasks
maxrichardjr
approved these changes
Jul 25, 2023
shaneodd
approved these changes
Jul 26, 2023
Pelentan
approved these changes
Jul 26, 2023
jampaul3
approved these changes
Jul 26, 2023
Pelentan
added
the
With QA
AmandaSumner
approved these changes
Jul 26, 2023
AmandaSumner
added
rc-ready
aerinkayne
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
empUID is passed into the API, but it's not used in the associated PHP function: https://github.com/department-of-veterans-affairs/LEAF/blob/master/LEAF_Nexus/sources/Employee.php#L87