Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsonify): parse returning undefined instead of the number #2738

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(jsonify): parse returning undefined instead of the number #2738

wants to merge 5 commits into from

Conversation

DevJoaoLopes
Copy link
Contributor

close #2736

marvinhagemeister
marvinhagemeister reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for making a PR.

@DevJoaoLopes
Copy link
Contributor Author

Taking advantage, I would like to know if it would be possible to join the list of contributors to the project. I've been using deno and fresh in my daily life and I've been trying more and more to contribute here. What do you think @marvinhagemeister ?

@DevJoaoLopes
Copy link
Contributor Author

@marvinhagemeister Can we merge this PR?

@DevJoaoLopes
Copy link
Contributor Author

@marvinhagemeister @lucacasonato How can we proceed with this PR 😄 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsonify parse -1 into undefined
2 participants
@DevJoaoLopes @marvinhagemeister