feat: add jsx-no-comment-text-nodes rule #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Nov 29, 2024
| fn jsx_text(&mut self, node: &JSXText, ctx: &mut Context) { | ||
| // | ||
| let value = &node.inner.value; | ||
| if value.starts_with("//") || value.starts_with("/*") { |
There was a problem hiding this comment.
Should these be stricter checks? Eg. ensuring there are only single lines or for block comments that it ends with */?
There was a problem hiding this comment.
This is too difficult to do, because of expression nodes. In practice this is imo good enough.
a = <p>/* foo {text}</p>
marvinhagemeister
force-pushed
the
no-comment-text
branch
from
bf480eb to
af4f455
Compare
bartlomieju
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing code comments as JSX text nodes is a common mistake. This Lint rule checks if a code comment was accidentally passed as JSX text by checking if it starts with
//or/*.