fix(prefer-primordials): allow private identifier in in expression

denoland · Dec 6, 2024 · fd6f455 · fd6f455
1 parent b722829
commit fd6f455
Showing 1 changed file with 34 additions and 14 deletions.
diff --git a/src/rules/prefer_primordials.rs b/src/rules/prefer_primordials.rs
@@ -713,20 +713,24 @@ impl Handler for PreferPrimordialsHandler {
   fn bin_expr(&mut self, bin_expr: &ast_view::BinExpr, ctx: &mut Context) {
     use ast_view::BinaryOp;
 
-    if matches!(bin_expr.op(), BinaryOp::InstanceOf) {
-      ctx.add_diagnostic_with_hint(
-        bin_expr.range(),
-        CODE,
-        PreferPrimordialsMessage::InstanceOf,
-        PreferPrimordialsHint::InstanceOf,
-      );
-    } else if matches!(bin_expr.op(), BinaryOp::In) {
-      ctx.add_diagnostic_with_hint(
-        bin_expr.range(),
-        CODE,
-        PreferPrimordialsMessage::In,
-        PreferPrimordialsHint::In,
-      );
+    match bin_expr.op() {
+      BinaryOp::InstanceOf => {
+        ctx.add_diagnostic_with_hint(
+          bin_expr.range(),
+          CODE,
+          PreferPrimordialsMessage::InstanceOf,
+          PreferPrimordialsHint::InstanceOf,
+        );
+      }
+      BinaryOp::In if !bin_expr.left.is::<ast_view::PrivateName>() => {
+        ctx.add_diagnostic_with_hint(
+          bin_expr.range(),
+          CODE,
+          PreferPrimordialsMessage::In,
+          PreferPrimordialsHint::In,
+        );
+      }
+      _ => {}
     }
   }
 }
@@ -913,6 +917,15 @@ function foo(): Array<any> {}
       r#"
 type p = Promise<void>;
       "#,
+      r#"
+class A {
+  #brand;
+
+  static is(obj) {
+    return #brand in obj;
+  }
+}
+      "#,
     };
   }
 
@@ -1294,6 +1307,13 @@ new DataView(new ArrayBuffer(10)).byteOffset;
           hint: PreferPrimordialsHint::In,
         },
       ],
+      r#"a in A"#: [
+        {
+          col: 0,
+          message: PreferPrimordialsMessage::In,
+          hint: PreferPrimordialsHint::In,
+        },
+      ],
       r#"a instanceof A"#: [
         {
           col: 0,