Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape special chars when rendering Wasm module #978

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

bartlomieju
Copy link
Member

Closes #975

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (0c7f83e) to head (4e230bf).
Report is 177 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   81.43%   81.75%   +0.31%     
==========================================
  Files          97       98       +1     
  Lines       23877    25672    +1795     
==========================================
+ Hits        19445    20988    +1543     
- Misses       4432     4684     +252     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

core/modules/map.rs Outdated Show resolved Hide resolved
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one comment.

@bartlomieju bartlomieju enabled auto-merge (squash) November 21, 2024 22:56
@bartlomieju bartlomieju merged commit 2593d5c into denoland:main Nov 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special character in import/export name of Wasm module causes error
3 participants