Make is_native_error reentrant for error formatting (#968)

denoland · Nov 19, 2024 · 6284399 · 6284399
1 parent d82bf9d
commit 6284399
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/core/ops_builtin_types.rs b/core/ops_builtin_types.rs
@@ -80,7 +80,7 @@ pub fn op_is_module_namespace_object(value: &v8::Value) -> bool {
   value.is_module_namespace_object()
 }
 
-#[op2(fast, no_side_effects)]
+#[op2(fast, reentrant)] // may be invoked by `format_exception_cb`
 pub fn op_is_native_error(value: &v8::Value) -> bool {
   value.is_native_error()
 }

diff --git a/core/runtime/tests/jsrealm.rs b/core/runtime/tests/jsrealm.rs
@@ -25,6 +25,7 @@ fn test_set_format_exception_callback_realms() {
         format!(
           r#"
           Deno.core.ops.op_set_format_exception_callback((error) => {{
+            Deno.core.isNativeError(error); // test reentrancy
             return `{realm_name} / ${{error}}`;
           }});
         "#