Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(check): compiler options from workspace members #27009

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

fix(check): compiler options from workspace members #27009

wants to merge 11 commits into from
+315 −26

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Nov 22, 2024 •
edited
Loading

Closes #24504.
Blocked by denoland/deno_config#143.
Blocked by crate updates in #27096.

dsherret
dsherret reviewed Nov 23, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add needed deno_config APIs, currently using hacks but it works.

Considering the 2.1 release passed, maybe let's spend the time to do this right before merging?

@nayeemrmn
Copy link
Collaborator Author

Yeah this is not for landing yet

@nayeemrmn nayeemrmn marked this pull request as draft November 23, 2024 02:46
@nayeemrmn nayeemrmn added the ci-draft Run the CI on draft PRs. label Nov 26, 2024
@bartlomieju bartlomieju added this to the 2.2.0 milestone Nov 26, 2024
@nayeemrmn nayeemrmn mentioned this pull request Nov 26, 2024
Open
@nayeemrmn nayeemrmn changed the title feat(check): compiler options from workspace members fix(check): compiler options from workspace members Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci-draft Run the CI on draft PRs.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Support compilerOptions in workspace members
3 participants
@nayeemrmn @dsherret @bartlomieju