feat(reply): implement ftp::reply::is_intermediate() method

deniskovalchuk · Sep 30, 2023 · f331049 · f331049
1 parent 5bb3de9
commit f331049
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/include/ftp/reply.hpp b/include/ftp/reply.hpp
@@ -43,6 +43,8 @@ class reply
 
     [[nodiscard]] bool is_negative() const;
 
+    [[nodiscard]] bool is_intermediate() const;
+
     [[nodiscard]] std::uint16_t get_code() const;
 
     [[nodiscard]] const std::string & get_status_string() const;

diff --git a/src/reply.cpp b/src/reply.cpp
@@ -48,6 +48,11 @@ bool reply::is_negative() const
     return code_ != unspecified && code_ >= 400;
 }
 
+bool reply::is_intermediate() const
+{
+    return code_ != unspecified && code_ >= 300 && code_ < 400;
+}
+
 std::uint16_t reply::get_code() const
 {
     return code_;

diff --git a/test/reply.cpp b/test/reply.cpp
@@ -36,6 +36,7 @@ TEST(reply, construct)
         EXPECT_EQ("", reply.get_status_string());
         EXPECT_FALSE(reply.is_positive());
         EXPECT_FALSE(reply.is_negative());
+        EXPECT_FALSE(reply.is_intermediate());
     }
 
     {
@@ -44,6 +45,7 @@ TEST(reply, construct)
         EXPECT_EQ("120 Service ready in 2 minutes.", reply.get_status_string());
         EXPECT_TRUE(reply.is_positive());
         EXPECT_FALSE(reply.is_negative());
+        EXPECT_FALSE(reply.is_intermediate());
     }
 
     {
@@ -52,6 +54,7 @@ TEST(reply, construct)
         EXPECT_EQ("220 FTP server is ready.", reply.get_status_string());
         EXPECT_TRUE(reply.is_positive());
         EXPECT_FALSE(reply.is_negative());
+        EXPECT_FALSE(reply.is_intermediate());
     }
 
     {
@@ -60,6 +63,7 @@ TEST(reply, construct)
         EXPECT_EQ("331 Username ok, send password.", reply.get_status_string());
         EXPECT_TRUE(reply.is_positive());
         EXPECT_FALSE(reply.is_negative());
+        EXPECT_TRUE(reply.is_intermediate());
     }
 
     {
@@ -68,6 +72,7 @@ TEST(reply, construct)
         EXPECT_EQ("425 Can't open data connection.", reply.get_status_string());
         EXPECT_FALSE(reply.is_positive());
         EXPECT_TRUE(reply.is_negative());
+        EXPECT_FALSE(reply.is_intermediate());
     }
 
     {
@@ -76,6 +81,7 @@ TEST(reply, construct)
         EXPECT_EQ("532 Need account for storing files.", reply.get_status_string());
         EXPECT_FALSE(reply.is_positive());
         EXPECT_TRUE(reply.is_negative());
+        EXPECT_FALSE(reply.is_intermediate());
     }
 }