Merge branch 'base'

.gitattributes

@@ -1 +1 @@
-/package-lock.json linguist-generated=true binary
+/package-lock.json linguist-generated=true -diff merge

package.json

@@ -1,9 +1,9 @@
 {
   "scripts": {
     "build": "rm -rf dist && NODE_ENV=production tsc",
-    "format": "prettier --write .",
-    "format-verify": "prettier --check .",
-    "lint": "eslint .",
+    "format": "prettier --write . --log-level=warn",
+    "format-verify": "prettier --check . --log-level=warn",
+    "lint": "eslint . --fix",
     "prepublishOnly": "npm run verify && npm run build && publint",
     "start-building": "rm -rf dist && NODE_ENV=production tsc --watch",
     "test": "ava",

src/rules/no-double-negative-variables.test.ts

@@ -38,7 +38,7 @@ invalid(
 invalid(
   "array destructuring double negatives",
   noDoubleNegativeVariables,
-  `let [hideBor, noBaz, quux] = 0 as any`,
+  `let [<err>hideBor</err>, <err>noBaz</err>, quux] = 0 as any`,
   {
     count: 2,
   },
@@ -47,7 +47,7 @@ invalid(
 invalid(
   "deep destructuring double negative",
   noDoubleNegativeVariables,
-  `let { foo: [{ bar: hideQQQ }] } = 0 as any;`,
+  `let { foo: [{ bar: <err>hideQQQ</err> }] } = 0 as any;`,
 );
 
 invalid(

src/rules/no-imports-down.test.ts

@@ -14,6 +14,12 @@ invalid(
   "import {} from './getFoo/bar'",
 );
 
+invalid(
+  "no-imports-down errors only on the path",
+  noImportsDown,
+  "import {} from <err>'./getFoo/bar'</err>",
+);
+
 valid(
   "no-imports-down can import from packages at one level",
   noImportsDown,

src/rules/no-imports-down.ts

@@ -47,6 +47,7 @@ const rule: Rule = {
       const message = getMessage(importType);
       if (message)
         context.report({
+          loc: node.source?.loc,
           message: message.join(" "),
           node,
         });

src/tester/index.ts

@@ -24,15 +24,41 @@ const ruleTester = new RuleTester();
 export function invalid(
   name: string,
   rule: Rule,
+  /**
+   * Can contain <err>...</err> tags to indicate where the error should be
+   */
   code: string,
   options: { count?: number; ruleOptions?: unknown[] } = {},
 ) {
   test(name, (t) => {
-    const blankError = {};
-    const errors = Array.from(new Array(options.count || 1)).map(
-      () => blankError,
-    );
-    ruleTester.run(name, rule as any, {
+    const errors: Omit<TSESLint.TestCaseError<string>, "messageId">[] =
+      Array.from(new Array(options.count || 1)).map(() => ({}));
+    function countPos(s: string) {
+      const lines = s.split("\n");
+      const last = lines[lines.length - 1];
+      return { col: last.length + 1, line: lines.length };
+    }
+    let errNum = 0;
+    while (code.includes("<err>")) {
+      const [before, ..._b] = code.split("<err>");
+      const b = _b.join("<err>");
+      if (!b.includes("</err>")) throw new Error("No closing </err> tag");
+      const [inside, ..._after] = b.split("</err>");
+      const after = _after.join("</err>");
+      const start = countPos(before);
+      const end = countPos(before + inside);
+      errors[errNum] = {
+        ...(errors[errNum] ?? {}),
+        column: start.col,
+        endColumn: end.col,
+        endLine: end.line,
+        line: start.line,
+      };
+      code = before + inside + after;
+      errNum += 1;
+    }
+
+    ruleTester.run("dummy rule name for test " + name, rule as any, {
       invalid: [
         { code, errors: errors as any, options: options.ruleOptions || [] },
       ],
@@ -49,7 +75,7 @@ export function valid(
   options: { ruleOptions?: unknown[] } = {},
 ) {
   test(name, (t) => {
-    ruleTester.run("dummy-name", rule as any, {
+    ruleTester.run("dummy rule name for test " + name, rule as any, {
       invalid: [],
       valid: [
         {