Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-release-notes --text special chars #4751

Merged
merged 5 commits into from
Jan 5, 2025
Merged

update-release-notes --text special chars #4751

merged 5 commits into from
Jan 5, 2025

Conversation

inbalapt1
Copy link
Contributor

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-12202

Description

@inbalapt1 inbalapt1 self-assigned this Jan 1, 2025
@inbalapt1 inbalapt1 requested a review from omerKarkKatz January 1, 2025 14:09
omerKarkKatz
omerKarkKatz reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@omerKarkKatz omerKarkKatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please see the comment and add a UT.

demisto_sdk/commands/update_release_notes/update_rn.py Outdated Show resolved Hide resolved
@inbalapt1 inbalapt1 requested a review from omerKarkKatz January 5, 2025 10:05
@inbalapt1 inbalapt1 merged commit 394cbb3 into master Jan 5, 2025
25 checks passed
@inbalapt1 inbalapt1 deleted the fix-text-release-notes branch January 5, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerKarkKatz omerKarkKatz omerKarkKatz approved these changes

Assignees

@inbalapt1 inbalapt1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inbalapt1 @omerKarkKatz