Add section and sectionOrder validations.
#4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog(s) in markdown:
|
YuvHayun
approved these changes
Jan 2, 2025
demisto_sdk/commands/validate/validators/ST_validators/ST111_no_exclusions_schema.py
Outdated
Show resolved
Hide resolved
rshunim
reviewed
Jan 2, 2025
demisto_sdk/commands/content_graph/strict_objects/integration.py
Outdated
Show resolved
Hide resolved
rshunim
approved these changes
Jan 2, 2025
AradCarmi
approved these changes
Jan 2, 2025
| """ | ||
| if "sectionOrder" in data and "sectionorder" not in data: | ||
| data["sectionorder"] = data.pop("sectionOrder") | ||
| elif "sectionOrder" in data and "sectionorder" in data: |
There was a problem hiding this comment.
Why would we have sectionOrder and sectionorder in the same yml? Wouldn't we want to fail this case?
There was a problem hiding this comment.
Thought we agreed on combining the two (Union) in our initial discussion with Shunim
There was a problem hiding this comment.
Do we have an example of such a case?
demisto_sdk/commands/validate/validators/ST_validators/ST111_no_exclusions_schema.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/ST_validators/ST111_no_exclusions_schema.py
Outdated
Show resolved
Hide resolved
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-5406
Description
This PR adds to the ST-110 validation by fixing some pydantic models.
The addition will make sure ST-110 will support: