fixed review comments

demisto · Mar 14, 2022 · 325e2a5 · 325e2a5
1 parent 74ed760
commit 325e2a5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,7 @@
 [1]: https://pypi.org/project/demisto-py/#history
 
 ## 3.1.2
-* Added auth_id to support `XSIAM` instances.
+* Add support to Cortex XSIAM.
 
 ## 3.1.1
 * Support `skipValidation` argument in `upload_content_packs` to skip upload packs validation, use when migrating existing custom content to packs.

diff --git a/README.md b/README.md
@@ -25,8 +25,8 @@ as the following environment variables (env variables will be used if parameters
 * DEMISTO_API_KEY
 * DEMISTO_USERNAME
 * DEMISTO_PASSWORD
-* DEMISTO_AUTH_ID (for XSIAM, If is set it means we should use the XSIAM api)
 * DEMISTO_VERIFY_SSL (true/false. Default: true)
+* XSIAM_AUTH_ID (for Cortex XSIAM only. If set, Cortex XSIAM API will be used)
 * SSL_CERT_FILE (specify an alternate certificate bundle)
 
 ### 2. Create a Demisto client instance with the api-key and server-url
@@ -42,11 +42,11 @@ api_instance = demisto_client.configure(base_url=host, api_key=api_key)
 
 ```
 
-**on the XSIAM we nead to add the auth_id**
+**For Cortex XSIAM, we need to set the auth_id**
 ```python
 import demisto_client
 
-# Also possible to set env variables: DEMISTO_API_KEY and DEMISTO_BASE_URL
+# Also possible to set env variables: DEMISTO_API_KEY, DEMISTO_BASE_URL and XSIAM_AUTH_ID
 api_key = 'YOUR_API_KEY'
 auth_id = 'THE AUTHORIZATION ID'
 host = 'https://YOUR_XSIAM_HOST'

diff --git a/demisto_client/__init__.py b/demisto_client/__init__.py
@@ -28,10 +28,10 @@ def configure(base_url=None, api_key=None, verify_ssl=None, proxy=None, username
 
     * DEMISTO_BASE_URL
     * DEMISTO_API_KEY
-    * DEMISTO_AUTH_ID
     * DEMISTO_USERNAME
     * DEMISTO_PASSWORD
     * DEMISTO_VERIFY_SSL (true/false. Default: true)
+    * XSIAM_AUTH_ID
     * SSL_CERT_FILE (specify an alternate certificate bundle)
     * DEMISTO_CONNECTION_POOL_MAXSIZE (specify a connection pool max size)
 
@@ -53,7 +53,7 @@ def configure(base_url=None, api_key=None, verify_ssl=None, proxy=None, username
     if api_key is None:
         api_key = os.getenv('DEMISTO_API_KEY')
     if auth_id is None:
-        auth_id = os.getenv('DEMISTO_AUTH_ID')
+        auth_id = os.getenv('XSIAM_AUTH_ID')
     if username is None:
         username = os.getenv('DEMISTO_USERNAME')
     if password is None: