Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIM - MISP Threat Actor Galaxy Feed #37978

Merged
merged 19 commits into from
Jan 23, 2025
Merged

Conversation

Ni-Knight
Copy link
Contributor

@Ni-Knight Ni-Knight commented Jan 7, 2025

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-6988

Description

This feed download and ingests the data in the MISP threat actor galaxy.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Jan 7, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/FeedMISPThreatActors/Integrations/FeedMISPThreatActors
   FeedMISPThreatActors.py1131784%347, 427, 472–473, 483, 537, 552–553, 568–569, 572, 574–576, 578–580
TOTAL1131784% 

Tests Skipped Failures Errors Time
5 0 💤 0 ❌ 0 🔥 2.756s ⏱️

@Ni-Knight Ni-Knight requested review from samuelFain and JudahSchwartz and removed request for samuelFain January 9, 2025 09:49
@Ni-Knight Ni-Knight added the bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url label Jan 9, 2025
@JudahSchwartz JudahSchwartz requested review from talzich and removed request for JudahSchwartz January 9, 2025 13:47
@talzich talzich requested a review from MLainer1 January 13, 2025 12:12
@talzich talzich added the Contribution Thank you! Contributions are always welcome! label Jan 14, 2025
Copy link
Contributor

@talzich talzich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dror!
See my comments. Also, we need to have a get-indicators command in this integration.

Cheers

@Ni-Knight Ni-Knight requested a review from talzich January 14, 2025 16:16
@Ni-Knight
Copy link
Contributor Author

@talzich - Added get-indicators and the test for it.

Copy link
Contributor

@MLainer1 MLainer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ShirleyDenkberg
Copy link
Contributor

@Ni-Knight Need content for the pack README.
@MLainer1 @talzich Doc review completed.

@talzich talzich merged commit 58d38ca into master Jan 23, 2025
17 checks passed
@talzich talzich deleted the dra-misp-threat-actors-galaxy branch January 23, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url Contribution Thank you! Contributions are always welcome! docs-approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants