Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DatadogCloudSIEM] MyPy In Docker #37886

Merged
merged 14 commits into from
Jan 6, 2025
Merged

[DatadogCloudSIEM] MyPy In Docker #37886

merged 14 commits into from
Jan 6, 2025
+9 −3

Conversation

shmuel44
Copy link
Contributor

@shmuel44 shmuel44 commented Dec 31, 2024 •
edited
Loading

Related Issues

fixes: link to the issue

Description

Screenshot 2024-12-31 at 16 25 33

@shmuel44 shmuel44 self-assigned this Dec 31, 2024
@shmuel44 shmuel44 requested a review from BEAdi December 31, 2024 14:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/DatadogCloudSIEM/Integrations/DatadogCloudSIEM
   DatadogCloudSIEM.py4436086%337, 395–396, 406–407, 428, 430, 438, 504, 544, 593, 645, 773, 809, 849, 1006, 1037, 1039, 1120, 1175, 1207, 1209, 1215, 1221, 1236, 1292–1294, 1297–1299, 1302–1304, 1309, 1314, 1321, 1323, 1350–1358, 1360, 1378–1383, 1385–1390
TOTAL4436086% 

Tests Skipped Failures Errors Time
48 0 💤 0 ❌ 0 🔥 2.480s ⏱️

@CLAassistant
Copy link

CLAassistant commented Jan 1, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shmuel44 shmuel44 marked this pull request as ready for review January 5, 2025 03:09
BEAdi
BEAdi approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that the docker update is fine with 3.12

@shmuel44 shmuel44 merged commit dd9280d into master Jan 6, 2025
17 checks passed
@shmuel44 shmuel44 deleted the sk_mypy_DatadogCloudSIEM branch January 6, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BEAdi BEAdi BEAdi approved these changes

Assignees

@shmuel44 shmuel44

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shmuel44 @CLAassistant @BEAdi