Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New 1Password XSIAM Integration #37730

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

New 1Password XSIAM Integration #37730

wants to merge 62 commits into from

Conversation

kamalq97
Copy link
Contributor

@kamalq97 kamalq97 commented Dec 17, 2024 •
edited
Loading

Related Issues

fixes: link to the issue

Description

Create a new '1Password' pack, including an XSIAM integration that can fetch three types of events:

  • Audit events
  • Item usage actions
  • Sign in attempts

@kamalq97 kamalq97 added inprogress It means the PR is still on progress, and should not be merged even if the build is green or approve python Pull requests that update Python code labels Dec 17, 2024
@kamalq97 kamalq97 self-assigned this Dec 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/OnePassword/Integrations/OnePassword
   OnePassword.py1051288%160, 179–181, 184–185, 267–268, 303–304, 307, 309
TOTAL1051288% 

Tests Skipped Failures Errors Time
36 0 💤 0 ❌ 0 🔥 6.996s ⏱️

@kamalq97 kamalq97 requested review from JasBeilin and ShirleyDenkberg and removed request for JasBeilin December 23, 2024 14:58
@kamalq97 kamalq97 removed the inprogress It means the PR is still on progress, and should not be merged even if the build is green or approve label Dec 23, 2024
@kamalq97 kamalq97 marked this pull request as ready for review December 23, 2024 14:59
@kamalq97 kamalq97 changed the title 1Password Event Collector [DRAFT] New 1Password XSIAM Event Collector Dec 23, 2024
dorschw
dorschw reviewed Dec 23, 2024
View reviewed changes
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector_test.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector_test.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector_test.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector_test.py Outdated Show resolved Hide resolved
Packs/1Password/pack_metadata.json Outdated Show resolved Hide resolved
ShirleyDenkberg
ShirleyDenkberg reviewed Dec 23, 2024
View reviewed changes
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.yml Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.yml Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.yml Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector_description.md Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector_description.md Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/README.md Outdated Show resolved Hide resolved
Packs/1Password/README.md Outdated Show resolved Hide resolved
@kamalq97 kamalq97 requested review from JasBeilin and removed request for shmuel44 December 29, 2024 14:29
JasBeilin
JasBeilin requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, check my comments.

Packs/1Password/Integrations/OnePasswordEventCollector/test_data/auditevents_response_2.json Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/test_data/auditevents_response_1.json Outdated Show resolved Hide resolved
.../1Password/Integrations/OnePasswordEventCollector/test_data/auditevents_expected_events.json Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/README.md Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/README.md Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.py Outdated Show resolved Hide resolved
Packs/1Password/Integrations/OnePasswordEventCollector/OnePasswordEventCollector.py Outdated Show resolved Hide resolved
@kamalq97 kamalq97 requested a review from JasBeilin January 1, 2025 14:49
@kamalq97 kamalq97 changed the title New 1Password XSIAM Event Collector New 1Password XSIAM Integration Jan 7, 2025
@kamalq97
Rename (Again)
ecea73c
@kamalq97
Rename pack
e099ef2
@kamalq97
Update docker_native_image_config.json
46af80c
@kamalq97
Merge branch 'master' into CIAC-12024-1password-xsiam-collector-v1
b333c44
@kamalq97
Update README.md
5f0058c
@kamalq97
Improve handling of fetch run edge case
2ddaed7 
* Added event 'timestamp_ms' field to match `DATE_FILTER_FORMAT` (in ms precision)
* Use 'timestamp_ms' to create `next_run_ids_to_skip` (list of already fetched IDs to skip)
* Update test data and unit tests accordingly
JasBeilin
JasBeilin approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw left review comments

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@JasBeilin JasBeilin JasBeilin approved these changes

Assignees

@kamalq97 kamalq97

@ShirleyDenkberg ShirleyDenkberg

Labels
docs-approved python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamalq97 @ShirleyDenkberg @JasBeilin @dorschw