Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] Tenable.sc - Content Pack Update #35341

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@ivette314

Notes

Tested on a customer's environment to ensure that the call functions properly. However, a sample Postman API call works and returns a list of restricted IPs, and this integration testing does not return any errors but also does not return any data. We are hoping it's some sort of minor flunk and once the pack is officially released the call works as expected.

Auto-Generated Documentation Requiring Modification

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jul 9, 2024
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_ivette314-contrib-Tenable_sc July 9, 2024 19:17
@content-bot content-bot requested a review from MosheEichler July 9, 2024 19:18
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @MosheEichler will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution, please ask the reviewer to update your information in the pack contributors file. See more information here link

@content-bot content-bot added the Contribution Form Filled Whether contribution form filled or not. label Jul 9, 2024
@MosheEichler MosheEichler removed their request for review July 10, 2024 07:35
@MosheEichler MosheEichler removed their assignment Jul 10, 2024
@thefrieddan1
Copy link
Contributor

Thank @ivette314 you for your contribution it looks good.
Please schedule a demo or attach a video session where you demonstrate the added get-organization command.
You can schedule a demo with me on slack on DFIR workspace 'Danny Fried'.
Thanks

@thefrieddan1
Copy link
Contributor

Hi @ivette314, we haven’t heard from you in a while.
Do you need any help with the pull request?

Please feel free to reach out to me here or on Slack.
Thanks again for contributing to our repo, hope to hear from you soon.

### tenable-sc-list-repositories

***
Requires security manager role. Get a list of Tenable.sc scan repositories.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Requires security manager role. Get a list of Tenable.sc scan repositories.
Get a list of Tenable.sc scan repositories. Requires security manager role.

Comment on lines 1077 to 1078
| managed_users_groups | Comma-separated list of session user's role that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |
| managed_objects_groups | Comma-separated list of the session user's role that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| managed_users_groups | Comma-separated list of session user's role that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |
| managed_objects_groups | Comma-separated list of the session user's role that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |
| managed_users_groups | Comma-separated list of session user's roles that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |
| managed_objects_groups | Comma-separated list of the session user's roles that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |

| managed_users_groups | Comma-separated list of session user's role that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |
| managed_objects_groups | Comma-separated list of the session user's role that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |
| group_id | Valid group ID whose users can be managed by the created user. Default is 0. | Required |
| responsible_asset_id | Default is 0. ID of a valid, usable, accessible asset. Use tenable-sc-list-assets to get all available assets. -1 is not set, 0 is all assets, and other numbers are asset ID. Default is 0. | Required |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| responsible_asset_id | Default is 0. ID of a valid, usable, accessible asset. Use tenable-sc-list-assets to get all available assets. -1 is not set, 0 is all assets, and other numbers are asset ID. Default is 0. | Required |
| responsible_asset_id | ID of a valid, usable, accessible asset. Use tenable-sc-list-assets to get all available assets. -1 is not set, 0 is all assets, and other numbers are asset ID. Default is 0. | Required |

| group_id | Valid group ID whose users can be managed by the created user. | Optional |
| responsible_asset_id | ID of a valid, usable, accessible asset. Use tenable-sc-list-assets to get all available assets. -1 is not set, 0 is all assets, and other numbers are asset ID. | Optional |
| managed_users_groups | Comma-separated list of session user's role that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |
| managed_objects_groups | Comma-separated list of session user's role that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| managed_objects_groups | Comma-separated list of session user's role that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |
| managed_objects_groups | Comma-separated list of session user's role that can manage groups. Use tenable-sc-list-groups to get all available groups. Default is 0. | Optional |

| limit | The number of objects to return in one response (maximum limit is 200). Ignored when plugin_id is given. Default is 50. | Optional |
| is_active | Default is none. none - both active and passive Plugin Families are returned. true - Only active Plugin Families will be returned. false - Only passive Plugin Families will be returned. Ignored when plugin_id is given. Possible values are: true, false. | Optional |
| family_id | Family ID. Can be retrieved from the result of the tenable-sc-list-plugin-family command. | Required |
| plugins_id | Comma-separated list of plugin_ids, Can be retrieved from the result of the tenable-sc-list-plugin-family command with family_id as the argument. | Required |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| plugins_id | Comma-separated list of plugin_ids, Can be retrieved from the result of the tenable-sc-list-plugin-family command with family_id as the argument. | Required |
| plugins_id | Comma-separated list of plugin_ids. Can be retrieved from the result of the tenable-sc-list-plugin-family command with family_id as the argument. | Required |

| description | The asset description. | Optional |
| owner_id | The asset owner ID. | Optional |
| tag | The asset tag. | Optional |
| ip_list | Comma-separated list of the asset IPs list. | Optional |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| ip_list | Comma-separated list of the asset IPs list. | Optional |
| ip_list | Comma-separated list of the asset IPs. | Optional |

| repeat_rule_by_day | A comma-separated list of days of the week to run the schedule. Possible values are: SU, MO, TU, WE, TH, FR, SA. | Optional |
| asset_ids | Either no assets or comma-separated list of asset IDs to scan. Can be retrieved from the list-assets command. | Optional |
| scan_virtual_hosts | Default is false. Whether to include virtual hosts. Possible values are: true, false. Default is false. | Optional |
| ip_list | Comma-separated IPs to scan, e.g., 10.0.0.1,10.0.0.2 . | Optional |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| ip_list | Comma-separated IPs to scan, e.g., 10.0.0.1,10.0.0.2 . | Optional |
| ip_list | Comma-separated list of IPs to scan, e.g., 10.0.0.1,10.0.0.2 . | Optional |

| credentials | Comma-separated credentials IDs to use. Can be retrieved from the list-credentials command. | Optional |
| timeout_action | discard - do not import any of the results obtained by the scan to the database. import - Import the results of the current scan and discard the information for any unscanned targets. rollover-Import the results from the scan into the database and create a rollover scan that may be launched at a later time to complete the scan. Possible values are: discard, import, rollover. Default is import. | Optional |
| max_scan_time | Maximum scan run time in hours. Default is 1. | Optional |
| dhcp_tracking | Track hosts which have been issued new IP address, (e.g., DHCP). Possible values are: true, false. Default is false. | Optional |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| dhcp_tracking | Track hosts which have been issued new IP address, (e.g., DHCP). Possible values are: true, false. Default is false. | Optional |
| dhcp_tracking | Whether to track hosts that have been issued new IP address, (e.g., DHCP). Possible values are: true, false. Default is false. | Optional |

| max_scan_time | Maximum scan run time in hours. Default is 1. | Optional |
| dhcp_tracking | Track hosts which have been issued new IP address, (e.g., DHCP). Possible values are: true, false. Default is false. | Optional |
| enabled | Whether the schedule is enabled. The "enabled" field can only be set to "false" for schedules of type "ical". For all other schedules types, "enabled" is set to "true". Possible values are: true, false. Default is true. | Optional |
| rollover_type | Create a rollover scan scheduled to launch the next day at the same start time as the just completed scan. template-Create a rollover scan as a template for users to launch manually This field is required if the timeout_action is set to rollover. Default is nextDay. | Optional |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| rollover_type | Create a rollover scan scheduled to launch the next day at the same start time as the just completed scan. template-Create a rollover scan as a template for users to launch manually This field is required if the timeout_action is set to rollover. Default is nextDay. | Optional |
| rollover_type | Create a rollover scan scheduled to launch the next day at the same start time as the just completed scan. template-Create a rollover scan as a template for users to launch manually. This field is required if the timeout_action is set to rollover. Default is nextDay. | Optional |

Packs/Tenable_sc/Integrations/Tenable_sc/Tenable_sc.yml Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@thefrieddan1 Doc review completed. I recommend that edits I made in the README file be incorporated in the yml file.

@thefrieddan1 thefrieddan1 merged commit d4c9c79 into demisto:contrib/xsoar-contrib_ivette314-contrib-Tenable_sc Aug 14, 2024
15 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

DeanArbel pushed a commit that referenced this pull request Aug 18, 2024
…35889)

* "contribution update to pack 'Tenable.sc'"

* fix human readable output

* mid work

* mid work

* Parsing according to fields.

* yml description

* Added unit test for organization command.

* Fix RN

* revert changes to readme

* Add readme for new command

* pre-commit changes

* Apply suggestions from code review



* revert changes to section order.

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: Danny Fried <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
maimorag pushed a commit that referenced this pull request Aug 27, 2024
…35889)

* "contribution update to pack 'Tenable.sc'"

* fix human readable output

* mid work

* mid work

* Parsing according to fields.

* yml description

* Added unit test for organization command.

* Fix RN

* revert changes to readme

* Add readme for new command

* pre-commit changes

* Apply suggestions from code review



* revert changes to section order.

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: Danny Fried <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
xsoar-bot added a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
…35341) (demisto#35889)

* "contribution update to pack 'Tenable.sc'"

* fix human readable output

* mid work

* mid work

* Parsing according to fields.

* yml description

* Added unit test for organization command.

* Fix RN

* revert changes to readme

* Add readme for new command

* pre-commit changes

* Apply suggestions from code review



* revert changes to section order.

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: Danny Fried <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants