Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rasterize Latest Poppler #32997

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Rasterize Latest Poppler #32997

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a78b498
Rasterize Latest Poppler
tkatzir Feb 19, 2024
7d2953f
noqa F406
tkatzir Feb 19, 2024
13a04fd
Merge branch 'master' into rasterize-latest-poppler
tkatzir Feb 19, 2024
bc77979
Fix test
tkatzir Feb 19, 2024
9a17d68
Docker
tkatzir Feb 19, 2024
b6270dc
Docker
tkatzir Feb 20, 2024
dcca37b
Merge branch 'master' into rasterize-latest-poppler
tkatzir Mar 4, 2024
ce6cf95
Docker
tkatzir Mar 4, 2024
674bf59
Merge branch 'rasterize-latest-poppler' of github.com:demisto/content…
tkatzir Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Packs/rasterize/Integrations/rasterize/rasterize.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
category: Utilities

Check failure on line 1 in Packs/rasterize/Integrations/rasterize/rasterize.yml

View workflow job for this annotation

GitHub Actions / pre-commit / pre-commit

Validation Error DO106 

The docker image tag is not the latest numeric tag, please update it.
The docker image tag in the yml file is: 121.0.6167.88164
The latest docker image tag in docker hub is: 122.0.6261.88727

You can check for the most updated version of demisto/chromium here: https://hub.docker.com/r/demisto/chromium/tags 
To update the docker image run:
demisto-sdk format -ud -i Packs/rasterize/Integrations/rasterize/rasterize.yml
commonfields:
id: Rasterize
version: -1
Expand Down Expand Up @@ -355,7 +355,7 @@
- contextPath: InfoFile.Type
description: The type of the image/pdf file.
type: string
dockerimage: demisto/chromium:121.0.6167.87107
dockerimage: demisto/chromium:121.0.6167.88164
runonce: false
script: "-"
subtype: python3
Expand Down
6 changes: 6 additions & 0 deletions Packs/rasterize/Integrations/rasterize/rasterize_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,3 +317,9 @@ def test_log_warning():
from rasterize import pypdf_logger
assert pypdf_logger.level == logging.ERROR
assert pypdf_logger.level == logging.ERROR


def test_poppler_version():
import pdf2image
poppler_version = pdf2image.pdf2image._get_poppler_version("pdftoppm")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets have an e2e test like we have in ParseEmailFiles where we use test files and run the command and check for the output

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poppler is a C executable, and pdf2image is a Python wrapper.
In order to reproduce the issue I'll need a DocuSign doc, which we don't have.

assert poppler_version[0] > 20
6 changes: 6 additions & 0 deletions Packs/rasterize/ReleaseNotes/2_0_1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### Rasterize

- Updated the Docker image to: *demisto/chromium:121.0.6167.88164*.
2 changes: 1 addition & 1 deletion Packs/rasterize/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Rasterize",
"description": "Converts URLs, PDF files, and emails to an image file or PDF file.",
"support": "xsoar",
"currentVersion": "2.0.0",
"currentVersion": "2.0.1",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
Loading