Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devo v2 dev #32989

Merged
merged 21 commits into from
Mar 10, 2024
Merged

Devo v2 dev #32989

merged 21 commits into from
Mar 10, 2024

Conversation

namrata-metron
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

  • Refactored code for clarity and efficiency
  • Added error-checking mechanisms for robustness
  • Optimized database queries for faster execution
  • Improved documentation for ease of understanding and usage

Description

This pull request introduces optimizations and improvements to the write_to_table_command and write_to_lookup_table_command functionalities. The changes enhance performance, improve error handling, and streamline code for better maintainability.

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Feb 19, 2024
@content-bot content-bot changed the base branch from master to contrib/metron-labs_devo_V2-dev February 19, 2024 09:44
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @jbabazadeh will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Feb 19, 2024
@namrata-metron namrata-metron marked this pull request as draft February 19, 2024 10:30
namrata-metron

This comment was marked as outdated.

Sign in to view

@namrata-metron namrata-metron marked this pull request as ready for review February 19, 2024 10:33
jbabazadeh
jbabazadeh requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @namrata-metron
Thank you for your contribution!
Good work :)
Please see my comments.
Also-

  • please update the docker image to the latest- is: 1.0.0.87725.
    To update the docker image run:
    demisto-sdk format -ud -i Packs/Devo/Integrations/Devo_v2/Devo_v2.yml

  • You need to add more unit tests in order to reach a coverage of at least 78.07 percent (currently: 77.84 percent).

Please feel free to reach out to me with any questions
Thanks again

Packs/Devo/Integrations/Devo_v2/Devo_v2.py Show resolved Hide resolved
Packs/Devo/Integrations/Devo_v2/Devo_v2.py Outdated Show resolved Hide resolved
Packs/Devo/Integrations/Devo_v2/Devo_v2.py Show resolved Hide resolved
Packs/Devo/ReleaseNotes/1_3_1.md Outdated Show resolved Hide resolved
@jbabazadeh jbabazadeh added the pending-contributor The PR is pending the response of its creator label Feb 20, 2024
jbabazadeh
jbabazadeh requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@namrata-metron ,thanks for the changes you made.
Please see my comment
Please add another test cause its still not reach the coverage is needed.
Also you need to sign our Contributor License Agreement

Packs/Devo/ReleaseNotes/1_3_1.md Outdated Show resolved Hide resolved
@jbabazadeh jbabazadeh removed the request for review from dansterenson February 29, 2024 11:19
@jbabazadeh
Copy link
Contributor

Hi @namrata-metron ,

We're ready for a demo. Please check this page, and let me know when you're available for one over DFIR.

Also can you please pull the changes from master? (merge from master into your branch)

@namrata-metron
Copy link
Contributor Author

Hi @jbabazadeh,
We are available for the demo meeting today, and our time zone is IST.

namrata-metron
namrata-metron commented Mar 1, 2024
View reviewed changes
Copy link
Contributor Author

@namrata-metron namrata-metron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes

@jbabazadeh jbabazadeh added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Mar 4, 2024
@jbabazadeh
Copy link
Contributor

Hi @namrata-metron ,
Please let me know if you're free tomorrow, Tuesday, at 14:00 IST?
and share your email, I'll send you an invitation for the call.

@namrata-metron
Copy link
Contributor Author

Hi @namrata-metron , Please let me know if you're free tomorrow, Tuesday, at 14:00 IST? and share your email, I'll send you an invitation for the call.

Thanks for the update! And I'm available tomorrow for the demo meeting. Here is my mail Id: [email protected]

@namrata-metron
Copy link
Contributor Author

Hi @jbabazadeh,
Can you please confirm regarding the status of the PR, is it ready for the merge?

jbabazadeh
jbabazadeh approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the demo

@jbabazadeh jbabazadeh merged commit 33be079 into demisto:contrib/metron-labs_devo_V2-dev Mar 10, 2024
24 of 25 checks passed
@content-bot content-bot mentioned this pull request Mar 10, 2024
Merged
5 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

jbabazadeh added a commit that referenced this pull request Mar 11, 2024
@content-bot @namrata-metron @jbabazadeh
Devo v2 dev (#32989) (#33282)
217cead 
* write_to_table_command & write_to_lookup_table_command changes

* updated test cases & bug fixes

* updated devo_write_to_table test case

* prevoius code reverted

* diff changes

* Bug fixes

* Validation checks & Unit test cases added

* code reverted & working on readme file

* readme file changes updated

* optional parameters check added

* code reverted

* updated test cases & implemented the requested suggestions

* reverted changes

* added additional unit test cases

* Docker image tag updated

* Updated the release note for latest docker image

* Docker Image updated

Co-authored-by: namrata-metron <[email protected]>
Co-authored-by: JudithB <[email protected]>
@jbabazadeh
Copy link
Contributor

Hi @namrata-metron ,
I merged the internal PR, and your update is now in the master branch of content repo.
Your update should be available in the marketplace within the next 72 hours.
Again, thank you very much for your contribution!

pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
@content-bot @namrata-metron
@jbabazadeh @pal-xmco
Devo v2 dev (demisto#32989) (demisto#33282)
df7064f 
* write_to_table_command & write_to_lookup_table_command changes

* updated test cases & bug fixes

* updated devo_write_to_table test case

* prevoius code reverted

* diff changes

* Bug fixes

* Validation checks & Unit test cases added

* code reverted & working on readme file

* readme file changes updated

* optional parameters check added

* code reverted

* updated test cases & implemented the requested suggestions

* reverted changes

* added additional unit test cases

* Docker image tag updated

* Updated the release note for latest docker image

* Docker Image updated

Co-authored-by: namrata-metron <[email protected]>
Co-authored-by: JudithB <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbabazadeh jbabazadeh jbabazadeh approved these changes

Assignees

@edik24 edik24

@jbabazadeh jbabazadeh

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@namrata-metron @CLAassistant @content-bot @jbabazadeh @edik24