Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that upload and master commits are different #32987

Closed
wants to merge 11 commits into from

Conversation

MosheEichler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related PRs

#32973

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@kobymeir kobymeir requested review from GuyAfik and removed request for yucohen February 19, 2024 08:38
.gitlab/ci/.gitlab-ci.global.yml Outdated Show resolved Hide resolved
.gitlab/ci/.gitlab-ci.global.yml Outdated Show resolved Hide resolved
.gitlab/ci/.gitlab-ci.global.yml Outdated Show resolved Hide resolved
.gitlab/ci/.gitlab-ci.global.yml Show resolved Hide resolved
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MosheEichler good job!!!

.gitlab/ci/.gitlab-ci.global.yml Outdated Show resolved Hide resolved
.gitlab/ci/.gitlab-ci.global.yml Outdated Show resolved Hide resolved
.gitlab/ci/.gitlab-ci.global.yml Show resolved Hide resolved
@MosheEichler MosheEichler requested a review from GuyAfik February 20, 2024 14:00
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MosheEichler looks great, wonderful job

@MosheEichler MosheEichler requested a review from GuyAfik February 26, 2024 19:48
@MosheEichler MosheEichler requested review from kobymeir and removed request for kobymeir February 28, 2024 12:02
@MosheEichler MosheEichler added the nightly-ok Indicates nightly was ran successfully label Mar 5, 2024
@content-bot
Copy link
Collaborator

This PR is marked as 'Stale' because it has been open for 30 days with no activity, it will be automatically closed in 15 days if no activity will be done. To reset the counter just remove the 'Stale' label or make changes to update this PR. If you wish this PR will never be marked as 'Stale' add the 'Ignore Stale'

@content-bot content-bot deleted the verify-upload-and-mster-commit branch April 22, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved nightly-ok Indicates nightly was ran successfully Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants