Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAXII2 Indicator Fields #32986

Merged
merged 10 commits into from
Mar 21, 2024
Merged

TAXII2 Indicator Fields #32986

merged 10 commits into from
Mar 21, 2024

Conversation

BEAdi
Copy link
Contributor

@BEAdi BEAdi commented Feb 19, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-33088

Description

Added the "set_default_fields" and "get_indicator_publication" functions to the IOCs of type "indicator". The following fields are added here: stixid, firstseenbysource, modified, description, publications.
The "confidence" and "languages" fields were also added by default to all IOCs.

Must have

  • Tests
  • Documentation

@BEAdi BEAdi self-assigned this Feb 19, 2024
@BEAdi BEAdi requested a review from MLainer1 as a code owner February 19, 2024 07:39
@github-actions GitHub Actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/TAXII2ApiModule
   TAXII2ApiModule.py6129684%245, 262, 267, 270, 272, 348, 365, 390–393, 397, 399, 401–404, 606–609, 640–643, 682–685, 718–721, 759–762, 795–798, 828–831, 858–861, 893–896, 926, 955, 989–990, 996, 1037, 1067–1070, 1104, 1126–1127, 1140, 1143, 1179, 1241, 1271–1277, 1295, 1320, 1324, 1389–1390, 1400, 1408, 1442–1443, 1462, 1465, 1473–1480
TOTAL6129684% 

Tests Skipped Failures Errors Time
50 0 💤 5 ❌ 0 🔥 2.033s ⏱️

sapirshuker added a commit that referenced this pull request Mar 4, 2024
@sapirshuker
add changes from #32986 PR
0875786
@BEAdi BEAdi requested review from jbabazadeh and removed request for MLainer1 March 21, 2024 09:37
jbabazadeh
jbabazadeh approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Just fix the validation that failed and solve the conflicts with master.

BEAdi added 2 commits March 21, 2024 14:15
@BEAdi
update versions
fca019b
@BEAdi
Merge branch 'master' into taxii2-indicator-fields
5e9a449 
# Conflicts:
#	Packs/FeedDHS/pack_metadata.json
#	Packs/FeedMitreAttackv2/pack_metadata.json
#	Packs/FeedTAXII/pack_metadata.json
@BEAdi BEAdi merged commit 7f7012e into master Mar 21, 2024
21 checks passed
@BEAdi BEAdi deleted the taxii2-indicator-fields branch March 21, 2024 13:59
dantavori pushed a commit that referenced this pull request Apr 2, 2024
@sapirshuker
STIX Parser API Module (#33106)
cb5e125 
* create stixparser class

* fix tests, add init to super

* revert tests

* fix pre-commit

* add unit42Feed

* fix tests

* rewrite create_attack_pattern_indicator

* rewrite parse_reports_and_report_relationships

* add RN

* Bump pack from version FeedUnit42v2 to 1.0.49.

* Bump pack from version FeedTAXII to 1.2.8.

* Bump pack from version FeedDHS to 2.0.34.

* add test

* add changes from #32986 PR

* add taxii2 tests,rewrite unit42

* made changes minimal

* fix tests, add RN for unit 42

* add impoer for the stix creator

* replace get_tlp feedmitreAttack

* fix tests

* add client,fix tests,add docker image

* resolve conflicts

* resolve conflicts

* resolve conflicts

* add ignore_external_id

* fix tests

* fix tests

* add rn

* fix tests

* add RN

* Bump pack from version CommonScripts to 1.14.13.

* fix test

* add docker image

* update docker image

* Bump pack from version CommonScripts to 1.14.14.

* fix relationships anf check delete

* change feed_data to fix tests

* add rn

* replace tests from taxiiserver to apimodule

* fix tests taxii2server

* replace asn with autonomous-system

* replace tests

* Bump pack from version CommonScripts to 1.14.15.

* fix taxii2 server issue, add pragam no cover

* add tests

* Bump pack from version CommonScripts to 1.14.16.

* Bump pack from version CommonScripts to 1.14.17.

* add test to api module, add defult value, fix tests

* add tests

* add tests

* fix flake8 mypy errors

* add_tests

* Bump pack from version TAXIIServer to 2.0.58.

* delete comments add docstrings

* Bump pack from version CommonScripts to 1.14.18.

* fix rn, delete comments

* Update FeedUnit42v2_test.py

* Update 2_0_58.md

* add required fields

* fixes

* Bump pack from version CommonScripts to 1.14.19.

* fixes

* delete comments

* delete comments

* fix confilcts

* fixes demo

* add rn add x509-certificate, add tests. add doc strings

* fix fields

* update RN

* fix x509

* fix add rn

* flake 8 errors

* fix errors

* fix flake 8 errors

* fix test and add #33431 changes

* fix flake8 errors add RN

* Bump pack from version CommonScripts to 1.14.21.

* docker image update

* CR comments, replace docker image

* fix uppercases name

* fix RN review

* Bump pack from version CommonScripts to 1.14.22.

* Bump pack from version TAXIIServer to 2.0.59.

* Update 2_0_59.md

* add test

* pre-commit update

* pre-commit

* Bump pack from version CommonScripts to 1.14.23.

* edit secret-ignore

* add memory_threshold

* Bump pack from version CommonScripts to 1.14.24.

* Bump pack from version Base to 1.33.45.

* update docker image

* Bump pack from version Base to 1.33.46.

* replace import, change tpb from 100,000 to 99,990

* replace import

* fix pre-commit error auto8

* fix pre-commit

* reduce tpb indicators to 99,000

* update docker taxii2apimodule

* reduce tpb indicators to 98,000

* Update 1_0_50.md

* reduce tpb indicators to 95,000

* Bump pack from version Base to 1.33.47.

* reduce tpb indicators to 90,000

---------

Co-authored-by: Content Bot <[email protected]>
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
@BEAdi @pal-xmco
TAXII2 Indicator Fields (demisto#32986)
cc07fca 
* add default_fields and publications to indicator

* add confidence and languages by default

* Fix tests

* add RN

* add known_words

* assign in one line

* update versions
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
@sapirshuker @pal-xmco
STIX Parser API Module (demisto#33106)
4c40765 
* create stixparser class

* fix tests, add init to super

* revert tests

* fix pre-commit

* add unit42Feed

* fix tests

* rewrite create_attack_pattern_indicator

* rewrite parse_reports_and_report_relationships

* add RN

* Bump pack from version FeedUnit42v2 to 1.0.49.

* Bump pack from version FeedTAXII to 1.2.8.

* Bump pack from version FeedDHS to 2.0.34.

* add test

* add changes from demisto#32986 PR

* add taxii2 tests,rewrite unit42

* made changes minimal

* fix tests, add RN for unit 42

* add impoer for the stix creator

* replace get_tlp feedmitreAttack

* fix tests

* add client,fix tests,add docker image

* resolve conflicts

* resolve conflicts

* resolve conflicts

* add ignore_external_id

* fix tests

* fix tests

* add rn

* fix tests

* add RN

* Bump pack from version CommonScripts to 1.14.13.

* fix test

* add docker image

* update docker image

* Bump pack from version CommonScripts to 1.14.14.

* fix relationships anf check delete

* change feed_data to fix tests

* add rn

* replace tests from taxiiserver to apimodule

* fix tests taxii2server

* replace asn with autonomous-system

* replace tests

* Bump pack from version CommonScripts to 1.14.15.

* fix taxii2 server issue, add pragam no cover

* add tests

* Bump pack from version CommonScripts to 1.14.16.

* Bump pack from version CommonScripts to 1.14.17.

* add test to api module, add defult value, fix tests

* add tests

* add tests

* fix flake8 mypy errors

* add_tests

* Bump pack from version TAXIIServer to 2.0.58.

* delete comments add docstrings

* Bump pack from version CommonScripts to 1.14.18.

* fix rn, delete comments

* Update FeedUnit42v2_test.py

* Update 2_0_58.md

* add required fields

* fixes

* Bump pack from version CommonScripts to 1.14.19.

* fixes

* delete comments

* delete comments

* fix confilcts

* fixes demo

* add rn add x509-certificate, add tests. add doc strings

* fix fields

* update RN

* fix x509

* fix add rn

* flake 8 errors

* fix errors

* fix flake 8 errors

* fix test and add demisto#33431 changes

* fix flake8 errors add RN

* Bump pack from version CommonScripts to 1.14.21.

* docker image update

* CR comments, replace docker image

* fix uppercases name

* fix RN review

* Bump pack from version CommonScripts to 1.14.22.

* Bump pack from version TAXIIServer to 2.0.59.

* Update 2_0_59.md

* add test

* pre-commit update

* pre-commit

* Bump pack from version CommonScripts to 1.14.23.

* edit secret-ignore

* add memory_threshold

* Bump pack from version CommonScripts to 1.14.24.

* Bump pack from version Base to 1.33.45.

* update docker image

* Bump pack from version Base to 1.33.46.

* replace import, change tpb from 100,000 to 99,990

* replace import

* fix pre-commit error auto8

* fix pre-commit

* reduce tpb indicators to 99,000

* update docker taxii2apimodule

* reduce tpb indicators to 98,000

* Update 1_0_50.md

* reduce tpb indicators to 95,000

* Bump pack from version Base to 1.33.47.

* reduce tpb indicators to 90,000

---------

Co-authored-by: Content Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbabazadeh jbabazadeh jbabazadeh approved these changes

Assignees

@BEAdi BEAdi

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BEAdi @jbabazadeh