Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Microsoft Graph Security] Update msg-update-alert documentation #32983

Merged
merged 6 commits into from
Feb 20, 2024
Merged

[Microsoft Graph Security] Update msg-update-alert documentation #32983

merged 6 commits into from
Feb 20, 2024

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Feb 18, 2024 •
edited
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Updated the documentation for the msg-update-alert command to include only the determination and classification options supported by Microsoft:

    • According to Microsoft docs:
      image

    • When using in Classification the benignPositive value we are getting:

    -d '{"classification": "benignPositive"}'
{"error":{"code":"InvalidRequestBody","message":"Request body is incorrect","innerError":{"date":"2024-02-18T16:46:20","request-id":"************************************","client-request-id":"************************************"}}}%

Must have

  • Tests
  • Documentation

@michal-dagan michal-dagan changed the title Update msg docs xsup 33542 [Microsoft Graph Security] Update *msg-update-alert* documentation Feb 18, 2024
@michal-dagan michal-dagan changed the title [Microsoft Graph Security] Update *msg-update-alert* documentation [Microsoft Graph Security] Update msg-update-alert documentation Feb 18, 2024
@michal-dagan michal-dagan marked this pull request as ready for review February 18, 2024 17:01
@michal-dagan michal-dagan merged commit a6e7972 into master Feb 20, 2024
19 checks passed
@michal-dagan michal-dagan deleted the update-msg-docs-xsup-33542 branch February 20, 2024 10:34
maimorag pushed a commit that referenced this pull request Feb 22, 2024
@michal-dagan @maimorag
[Microsoft Graph Security] Update msg-update-alert documentation (#32983
071ed07 
)

* update docs

* update dockers

* add "MSG-ediscovery-tpb" to skipped_tests
maimorag pushed a commit that referenced this pull request Feb 28, 2024
@michal-dagan @maimorag
[Microsoft Graph Security] Update msg-update-alert documentation (#32983
6c4514b 
)

* update docs

* update dockers

* add "MSG-ediscovery-tpb" to skipped_tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bziser bziser bziser approved these changes

@yucohen yucohen Awaiting requested review from yucohen

@sapirshuker sapirshuker Awaiting requested review from sapirshuker sapirshuker is a code owner

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michal-dagan @bziser