Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a limit to cs falcon search device command #32979

Merged
merged 21 commits into from
Feb 25, 2024

Conversation

omerKarkKatz
Copy link
Contributor

@omerKarkKatz omerKarkKatz commented Feb 18, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Added a limit parameter and a default value for the number of results returned from cs-falcon-search-device command.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Feb 18, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon
   CrowdStrikeFalcon.py274874173%355–356, 364, 410, 414, 426, 460–461, 463–464, 482, 604, 607, 635–644, 665, 740, 778–779, 781, 784–786, 834, 864, 923–924, 926, 931, 934–935, 950–952, 957, 960–961, 976–977, 979, 984, 987–988, 1016, 1018, 1023–1024, 1034, 1036, 1041–1042, 1152, 1269, 1271, 1298, 1300, 1317–1318, 1321–1326, 1328–1329, 1350, 1354, 1389, 1393, 1484, 1496–1497, 1499–1500, 1503, 1505, 1509–1510, 1546, 1555, 1560, 1589, 1591, 1619, 1623, 1655, 1657, 1786, 1791, 1802–1804, 1813–1817, 1830, 1833–1840, 1842, 1844, 1857, 1861, 1870, 1873–1874, 1877, 1886, 1889–1890, 1893, 1909, 1941, 1947–1950, 1953, 1957, 2007–2008, 2010, 2014, 2017, 2020, 2024–2025, 2028, 2043, 2199–2203, 2207, 2210, 2213–2214, 2217–2219, 2221, 2230, 2279–2280, 2282–2283, 2285–2287, 2320–2324, 2409, 2448–2451, 2454, 2457, 2459–2460, 2503–2505, 2508–2510, 2512, 2533, 2623, 2646–2647, 2704–2705, 2753, 3005–3006, 3191, 3295–3296, 3298, 3336–3341, 3391–3394, 3463, 3470, 3508, 3597, 3612, 3630, 3643, 3664–3667, 3680–3684, 3686–3687, 3689–3690, 3698–3706, 3713, 3757, 3763, 3791–3799, 3801–3802, 3810–3823, 3825–3827, 3829–3831, 3833–3835, 3837, 3839, 3841, 3853–3861, 3863–3873, 3881–3884, 3892–3895, 3931–3934, 3953–3958, 3960–3961, 3963–3970, 3980–3981, 3984, 4200–4202, 4209, 4231–4234, 4246, 4277–4280, 4296, 4328–4331, 4351–4352, 4362, 4375–4376, 4378, 4387–4390, 4431–4432, 4450–4453, 4498–4501, 4533, 4538–4539, 4564, 4568, 4580, 4582–4583, 4620–4621, 4627, 4648–4649, 4665–4666, 4680, 4694, 4697–4698, 4706, 4709–4710, 4721, 4725, 4764–4766, 4774–4776, 4778, 4805–4814, 4845, 4912–4915, 4918–4919, 4923–4926, 4929–4930, 4939–4940, 4942, 4944, 4946, 4948–4950, 4954, 4968–4972, 5037–5039, 5041, 5044, 5046, 5049, 5051–5053, 5055, 5057–5058, 5062–5065, 5070, 5072–5073, 5077–5078, 5080–5084, 5088, 5148, 5251, 5593, 5604, 5675, 5677, 5686, 5692, 5759, 5766, 5771, 5773, 5783, 5789, 5794, 5796–5797, 5799–5801, 5803, 5811, 5829, 5838, 5844, 5862, 5870, 5875, 5877–5878, 5880–5882, 5884, 5892, 5922, 5928, 5933, 5935, 5944, 5950, 5955, 5957–5958, 5960–5962, 5964, 5972, 6026, 6028–6029, 6031–6032, 6034, 6078–6079, 6081–6082, 6089, 6091, 6096, 6175, 6204–6205, 6213–6215, 6219, 6283, 6335, 6388, 6485, 6559–6560, 6562, 6564, 6581–6583, 6585–6590, 6592–6655, 6657–6668, 6675–6688, 6690–6691, 6693–6694, 6702–6703, 6705–6706, 6708–6709, 6711–6712, 6714–6718, 6722–6726, 6730–6731, 6733–6738, 6740–6743, 6745–6750, 6752–6795, 6797–6810, 6812, 6814–6815
TOTAL274874173% 

Tests Skipped Failures Errors Time
299 0 💤 0 ❌ 0 🔥 4.473s ⏱️

Merge branch 'master' of github.com:demisto/content into add_a_limit_to_cs_falcon_serach_device_command
Merge branch 'master' of github.com:demisto/content into add_a_limit_to_cs_falcon_serach_device_command
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

branch 'add_a_limit_to_cs_falcon_serach_device_command' of github.com:demisto/content into add_a_limit_to_cs_falcon_serach_device_command
@omerKarkKatz omerKarkKatz removed the request for review from amshamah419 February 22, 2024 19:20
@omerKarkKatz omerKarkKatz added the ForceMerge Forcing the merge of the PR despite the build status label Feb 25, 2024
@omerKarkKatz
Copy link
Contributor Author

force because of: 453 build sheet

@DeanArbel DeanArbel merged commit 8fcd682 into master Feb 25, 2024
20 of 21 checks passed
@DeanArbel DeanArbel deleted the add_a_limit_to_cs_falcon_serach_device_command branch February 25, 2024 18:31
maimorag pushed a commit that referenced this pull request Feb 26, 2024
* added a limit parameter to search device command

* updated release notes

* updated docker image

* updated the release notes

* add BC release ntoes and parameters to endpoint command

* docker update

* removed the params from the endpoint command

* updated the docker image

* removed unrelated files

* removed unrelated files

* Trigger-build
rundssoar pushed a commit to rundssoar/content that referenced this pull request Feb 28, 2024
* added a limit parameter to search device command

* updated release notes

* updated docker image

* updated the release notes

* add BC release ntoes and parameters to endpoint command

* docker update

* removed the params from the endpoint command

* updated the docker image

* removed unrelated files

* removed unrelated files

* Trigger-build
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* added a limit parameter to search device command

* updated release notes

* updated docker image

* updated the release notes

* add BC release ntoes and parameters to endpoint command

* docker update

* removed the params from the endpoint command

* updated the docker image

* removed unrelated files

* removed unrelated files

* Trigger-build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants