Get trail status #32960

kcelovic · 2024-02-15T20:26:20Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

Tests
Documentation

CLAassistant · 2024-02-15T20:26:26Z

All committers have signed the CLA.

content-bot · 2024-02-15T20:28:28Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

content-bot · 2024-02-15T20:28:29Z

Hi @kcelovic, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

YuvHayun

Hey @kcelovic, thx for your contribution!
Looks good in general, please make sure to add tests, sign the CLA, and address my comments.
Let me know if you have any questions.

Packs/AWS-CloudTrail/ReleaseNotes/1_1_0.md

Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.yml

Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py

Co-authored-by: Yuval Hayun <[email protected]>

…l.yml Co-authored-by: Yuval Hayun <[email protected]>

…l.py Co-authored-by: Yuval Hayun <[email protected]>

YuvHayun

The try & except comment is still relevant.
Also, tests are still needed.
Let me know when you're ready for re-review.

kcelovic · 2024-02-21T16:36:29Z

The try & except comment is still relevant. Also, tests are still needed. Let me know when you're ready for re-review.

@YuvHayun what kind of tests are needed? playbook test?

YuvHayun

Hey @kcelovic, I left some comments.
I'm talking about unit tests in the AWS-CloudTrail_test.py file.
Also, please make sure to update the readme to include the new command.
This can be done easily using the command `demisto-sdk generate-docs AWS-CloudTrail.yml'

Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py

Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.yml

YuvHayun · 2024-03-05T08:36:21Z

Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py

+'''EXECUTION BLOCK'''
+try:
+    if demisto.command() == 'test-module':
+        test_function()
+    if demisto.command() == 'aws-cloudtrail-create-trail':
+        create_trail(demisto.args())
+    if demisto.command() == 'aws-cloudtrail-delete-trail':
+        delete_trail(demisto.args())
+    if demisto.command() == 'aws-cloudtrail-describe-trails':
+        describe_trails(demisto.args())
+    if demisto.command() == 'aws-cloudtrail-update-trail':
+        update_trail(demisto.args())
+    if demisto.command() == 'aws-cloudtrail-start-logging':
+        start_logging(demisto.args())
+    if demisto.command() == 'aws-cloudtrail-stop-logging':
+        stop_logging(demisto.args())
+    if demisto.command() == 'aws-cloudtrail-lookup-events':
+        lookup_events(demisto.args())
+    if demisto.command() == 'aws-cloudtrail-get-trail-status':
+        get_trail_status(demisto.args())


Why did you remove the main()?
Please revert this change.
Also, the video you send me is not working for some reason.. please attach a new one.
Let's make sure to whole build flow is passing and that the video is attached and I'll move on with the pr.

changes reverted. new video attached.

Screen.Recording.2024-03-05.mov

@YuvHayun I am unsure why the tests are failing, let me know if additional changes are needed.

YuvHayun

Hey @kcelovic, I left some comments about places in the code that I think are failing for you.
Please also add tests to the new command you've added.

Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py

YuvHayun · 2024-03-06T07:51:24Z

Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py

+def handle_returning_date_to_string(date_obj: datetime | str | None) -> str:
    """Gets date object to string"""
-    # if the returning date is a string leave it as is.
-    if isinstance(date_obj, str):
+    # if the returning date is a string or None, leave it as is.
+    if date_obj is None or isinstance(date_obj, str):


Something is odd about this logic, if date_obj is None and we return it then the function should support None return (in that case let's also make sure it doesn't break any b/c).

What changes do you recommend here?

I would remove the None option from the argument anotation.

YuvHayun

And the unit tests.

YuvHayun · 2024-03-07T07:34:23Z

Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py

+def handle_returning_date_to_string(date_obj: datetime | str | None) -> str:
    """Gets date object to string"""
-    # if the returning date is a string leave it as is.
-    if isinstance(date_obj, str):
+    # if the returning date is a string or None, leave it as is.
+    if date_obj is None or isinstance(date_obj, str):


I would remove the None option from the argument anotation.

Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py

…l.py Co-authored-by: Yuval Hayun <[email protected]>

YuvHayun · 2024-03-10T07:45:31Z

Great job @kcelovic!
Thx for your contribution! merging to internal pr.

github-actions · 2024-03-10T07:46:57Z

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

* Get trail status (#32960) * "contribution update to pack "AWS - CloudTrail"" * made requested changes * Update Packs/AWS-CloudTrail/ReleaseNotes/1_1_0.md Co-authored-by: Yuval Hayun <[email protected]> * Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.yml Co-authored-by: Yuval Hayun <[email protected]> * Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.yml Co-authored-by: Yuval Hayun <[email protected]> * Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py Co-authored-by: Yuval Hayun <[email protected]> * removed try & except under get_trail_status function * fixed indent * fixed typo * fixed typo * made requested changes * updated docker version * updated docker * fixed typos * reverted change on package-lock.json * reverted changes as requested * revert package-lock.json * update dockerimage * Update 1_1_0.md * Update AWS-CloudTrail.py * Update AWS-CloudTrail.yml * Update 1_1_0.md * Update AWS-CloudTrail.py * Update AWS-CloudTrail.py * Update AWS-CloudTrail.py * Update AWS-CloudTrail.py * Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py Co-authored-by: Yuval Hayun <[email protected]> * Update AWS-CloudTrail_test.py * Update 1_1_0.md * Update AWS-CloudTrail.yml --------- Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: Yuval Hayun <[email protected]> * revert package-lcok * remove docker line --------- Co-authored-by: kcelovic <[email protected]> Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: Yuval Hayun <[email protected]> Co-authored-by: YuvHayun <[email protected]>

* Get trail status (demisto#32960) * "contribution update to pack "AWS - CloudTrail"" * made requested changes * Update Packs/AWS-CloudTrail/ReleaseNotes/1_1_0.md Co-authored-by: Yuval Hayun <[email protected]> * Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.yml Co-authored-by: Yuval Hayun <[email protected]> * Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.yml Co-authored-by: Yuval Hayun <[email protected]> * Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py Co-authored-by: Yuval Hayun <[email protected]> * removed try & except under get_trail_status function * fixed indent * fixed typo * fixed typo * made requested changes * updated docker version * updated docker * fixed typos * reverted change on package-lock.json * reverted changes as requested * revert package-lock.json * update dockerimage * Update 1_1_0.md * Update AWS-CloudTrail.py * Update AWS-CloudTrail.yml * Update 1_1_0.md * Update AWS-CloudTrail.py * Update AWS-CloudTrail.py * Update AWS-CloudTrail.py * Update AWS-CloudTrail.py * Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrail.py Co-authored-by: Yuval Hayun <[email protected]> * Update AWS-CloudTrail_test.py * Update 1_1_0.md * Update AWS-CloudTrail.yml --------- Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: Yuval Hayun <[email protected]> * revert package-lcok * remove docker line --------- Co-authored-by: kcelovic <[email protected]> Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: Yuval Hayun <[email protected]> Co-authored-by: YuvHayun <[email protected]>

xsoar-bot and others added 2 commits February 8, 2024 18:32

"contribution update to pack "AWS - CloudTrail""

1bb2877

made requested changes

87f7653

content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Feb 15, 2024

content-bot changed the base branch from master to contrib/kcelovic_get-trail-status February 15, 2024 20:28

content-bot assigned YuvHayun Feb 15, 2024

content-bot requested a review from YuvHayun February 15, 2024 20:28

YuvHayun requested changes Feb 18, 2024

View reviewed changes

YuvHayun added the pending-contributor The PR is pending the response of its creator label Feb 18, 2024

YuvHayun mentioned this pull request Feb 18, 2024

[Marketplace Contribution] AWS - CloudTrail - Content Pack Update #32800

Closed

3 tasks

kcelovic and others added 4 commits February 19, 2024 11:21

Update Packs/AWS-CloudTrail/ReleaseNotes/1_1_0.md

2e10684

Co-authored-by: Yuval Hayun <[email protected]>

Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrai…

bbd8550

…l.yml Co-authored-by: Yuval Hayun <[email protected]>

Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrai…

1a1e551

…l.yml Co-authored-by: Yuval Hayun <[email protected]>

Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrai…

e03fc32

…l.py Co-authored-by: Yuval Hayun <[email protected]>

YuvHayun requested changes Feb 20, 2024

View reviewed changes

removed try & except under get_trail_status function

27d22ff

kcelovic added 3 commits February 21, 2024 11:51

fixed indent

a6aa6a7

fixed typo

eb55e69

fixed typo

8d145af

YuvHayun requested changes Feb 22, 2024

View reviewed changes

kcelovic added 4 commits February 26, 2024 10:28

made requested changes

ceec7bf

updated docker version

2b14ee9

updated docker

84839a8

fixed typos

431c3a7

kcelovic requested a review from YuvHayun February 27, 2024 05:42

kcelovic requested a review from YuvHayun March 1, 2024 19:35

YuvHayun requested changes Mar 5, 2024

View reviewed changes

kcelovic added 8 commits March 5, 2024 09:00

Update AWS-CloudTrail.py

6ef6192

Update AWS-CloudTrail.yml

fa91979

Update 1_1_0.md

b7bacfb

Update AWS-CloudTrail.py

f0a0b2a

Update AWS-CloudTrail.py

4ecf498

Update AWS-CloudTrail.py

b7ccaba

Merge branch 'contrib/kcelovic_get-trail-status' into get-trail-status

e0b21ce

Merge branch 'contrib/kcelovic_get-trail-status' into get-trail-status

3421af0

kcelovic requested a review from YuvHayun March 5, 2024 22:59

YuvHayun requested changes Mar 6, 2024

View reviewed changes

Update AWS-CloudTrail.py

94ef568

YuvHayun requested changes Mar 7, 2024

View reviewed changes

kcelovic and others added 6 commits March 7, 2024 08:21

Update Packs/AWS-CloudTrail/Integrations/AWS-CloudTrail/AWS-CloudTrai…

1458f8f

…l.py Co-authored-by: Yuval Hayun <[email protected]>

Merge branch 'contrib/kcelovic_get-trail-status' into get-trail-status

1b47287

Merge branch 'contrib/kcelovic_get-trail-status' into get-trail-status

69abe45

Update AWS-CloudTrail_test.py

44919a4

Update 1_1_0.md

ff04ccf

Update AWS-CloudTrail.yml

dbd2b1c

kcelovic requested a review from YuvHayun March 8, 2024 22:35

YuvHayun approved these changes Mar 10, 2024

View reviewed changes

YuvHayun added the docs-approved label Mar 10, 2024

YuvHayun merged commit f3fdb70 into demisto:contrib/kcelovic_get-trail-status Mar 10, 2024
21 of 24 checks passed

content-bot mentioned this pull request Mar 10, 2024

Get trail status #33277

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get trail status #32960

Get trail status #32960

kcelovic commented Feb 15, 2024

CLAassistant commented Feb 15, 2024 •

edited

Loading

content-bot commented Feb 15, 2024

content-bot commented Feb 15, 2024

YuvHayun left a comment

YuvHayun left a comment

kcelovic commented Feb 21, 2024

YuvHayun left a comment

YuvHayun Mar 5, 2024

kcelovic Mar 5, 2024

kcelovic Mar 5, 2024

YuvHayun left a comment

YuvHayun Mar 6, 2024

kcelovic Mar 6, 2024

YuvHayun Mar 7, 2024

YuvHayun left a comment

YuvHayun Mar 7, 2024

YuvHayun commented Mar 10, 2024

github-actions bot commented Mar 10, 2024

Get trail status #32960

Get trail status #32960

Conversation

kcelovic commented Feb 15, 2024

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Must have

CLAassistant commented Feb 15, 2024 • edited Loading

content-bot commented Feb 15, 2024

content-bot commented Feb 15, 2024

YuvHayun left a comment

Choose a reason for hiding this comment

YuvHayun left a comment

Choose a reason for hiding this comment

kcelovic commented Feb 21, 2024

YuvHayun left a comment

Choose a reason for hiding this comment

YuvHayun Mar 5, 2024

Choose a reason for hiding this comment

kcelovic Mar 5, 2024

Choose a reason for hiding this comment

kcelovic Mar 5, 2024

Choose a reason for hiding this comment

YuvHayun left a comment

Choose a reason for hiding this comment

YuvHayun Mar 6, 2024

Choose a reason for hiding this comment

kcelovic Mar 6, 2024

Choose a reason for hiding this comment

YuvHayun Mar 7, 2024

Choose a reason for hiding this comment

YuvHayun left a comment

Choose a reason for hiding this comment

YuvHayun Mar 7, 2024

Choose a reason for hiding this comment

YuvHayun commented Mar 10, 2024

github-actions bot commented Mar 10, 2024

CLAassistant commented Feb 15, 2024 •

edited

Loading