Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] Abnormal Security - Content Pack Update #32959

Conversation

xsoar-bot
Copy link
Contributor

Warning
The changes in the contributed files were not made on the most updated pack versions

Item Name Contribution Pack Version Latest Pack Version
Abnormal Security 2.2.4 2.2.5

For the Reviewer:

  1. Compare the code of this PR with the latest version of the pack. Make sure you understand the changes the contributor intended to contribute, and solve the conflicts accordingly.
  2. In case improvements are needed, instruct the contributor to edit the code through the GitHub Codespaces and Not through the XSOAR UI.

For the Contributor:
@vipulkaneriya
In case you are requested by your reviewer to improve the code or to make changes, submit them through the GitHub Codespaces and Not through the XSOAR UI.

To use the GitHub Codespaces, do the following:

  1. Click the 'Code' button in the right upper corner of this PR.
  2. Click 'Create codespace on Transformers'.
  3. Click 'Authorize and continue'.
  4. Wait until your Codespace environment is generated. When it is, you can edit your code.
  5. Commit and push your changes to the head branch of the PR.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@vipulkaneriya

Notes

We had a challenge searching Threat log and Abuse campaign with limited search filter available for "abnormal-security-list-abuse-mailbox-campaigns" and "abnormal-security-list-threats". I reviewed the Abnormal Security API documentation and found out that we can narrow down list of Threat log and Abuse campaign by adding more search parameters. I added list result by sender, recipient, subject etc and hope your other customer will also benefits from this.

I request you to review other "list" command and add more search parameters.

refer:
https://app.swaggerhub.com/apis/abnormal-security/abx/1.4.2#/Abuse%20Mailbox/get_abusecampaigns
https://app.swaggerhub.com/apis/abnormal-security/abx/1.4.2#/Threats/get_threats

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Feb 15, 2024
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_vipulkaneriya-contrib-AbnormalSecurity February 15, 2024 19:21
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @shmuel44 will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

@shmuel44 shmuel44 requested review from JudahSchwartz and removed request for shmuel44 February 16, 2024 11:55
@shmuel44 shmuel44 assigned JudahSchwartz and unassigned shmuel44 Feb 16, 2024
@JudahSchwartz JudahSchwartz requested review from jbabazadeh and removed request for JudahSchwartz February 18, 2024 07:59
Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vipulkaneriya,
Thank you for your contribution!
Good work :)
Please see my comments
You can add the fixes / changes by using the resubmit option resubmit-a-content-pack, or by using GitHub Codespaces - GitHub Codespaces documentation.

@jbabazadeh jbabazadeh added pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Feb 19, 2024
@content-bot
Copy link
Collaborator

content-bot commented Feb 21, 2024

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/871737

Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the code looks good!

We're ready for a demo. Please check this page, and let me know when you're available for one over DFIR.

@MLainer1 MLainer1 removed their request for review February 25, 2024 13:25
@jbabazadeh
Copy link
Contributor

Hi @vipulkaneriya
Thanks for the demo!
We're currently awaiting approval from the Partner for this PR. Thanks!

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Mar 19, 2024
Copy link
Contributor

@wolyslager wolyslager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on behalf of Abnormal Security

@jbabazadeh jbabazadeh merged commit f96448e into demisto:contrib/xsoar-contrib_vipulkaneriya-contrib-AbnormalSecurity Mar 21, 2024
16 of 25 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

jbabazadeh added a commit that referenced this pull request Mar 25, 2024
…33462)

* [Marketplace Contribution] Abnormal Security - Content Pack Update (#32959)

* "contribution update to pack "Abnormal Security""

* Update Packs/AbnormalSecurity/ReleaseNotes/2_3_0.md

* Rename 2_3_0.md to 2_2_7.md

---------

Co-authored-by: JudithB <[email protected]>

* pre commit

* pre commit

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: JudithB <[email protected]>
Co-authored-by: jbabazadeh <[email protected]>
@jbabazadeh
Copy link
Contributor

Hi @vipulkaneriya,
I merged the internal PR, and your update is now in the master branch of content repo.
Your update should be available in the marketplace within the next 72 hours.
Again, thank you very much for your contribution!

pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
…emisto#33462)

* [Marketplace Contribution] Abnormal Security - Content Pack Update (demisto#32959)

* "contribution update to pack "Abnormal Security""

* Update Packs/AbnormalSecurity/ReleaseNotes/2_3_0.md

* Rename 2_3_0.md to 2_2_7.md

---------

Co-authored-by: JudithB <[email protected]>

* pre commit

* pre commit

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: JudithB <[email protected]>
Co-authored-by: jbabazadeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner-Approved pending-contributor The PR is pending the response of its creator post-demo TIM Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants