Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MISP 2.1.41 - Add Custom Object command #32881

Merged
merged 12 commits into from
Feb 15, 2024
Merged

MISP 2.1.41 - Add Custom Object command #32881

merged 12 commits into from
Feb 15, 2024

Conversation

mohlcyber
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

  • Added misp-add-custom-object command to add custom objects to MISP Events.
  • Updated the Docker image to: demisto/pymisp2:2.4.184.3.87593.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Feb 13, 2024
@content-bot content-bot changed the base branch from master to contrib/mohlcyber_contrib-mohlcyber-MISP February 13, 2024 23:09
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @mohlcyber, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

YuvHayun
YuvHayun requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The failures you mentioned on slack, seems to be due to test failures, please make sure to fix and ensure they pass.

Let me know if you need any help.

Packs/MISP/Integrations/MISPV3/MISPV3.py Outdated Show resolved Hide resolved
Packs/MISP/ReleaseNotes/2_1_41.md Outdated Show resolved Hide resolved
@YuvHayun YuvHayun added the pending-contributor The PR is pending the response of its creator label Feb 14, 2024
@mohlcyber
Copy link
Contributor Author

Based on our conversation reversed the Docker Image version. Recording is posted here: https://drive.google.com/file/d/17T8BQEVBMLcGTvI9hzUmHqhauJ86jeOK/view?usp=sharing

@YuvHayun YuvHayun added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 15, 2024
@YuvHayun
Copy link
Contributor

Hey @mohlcyber, the video looks good and the changes as well.. moving to instance-test.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/830825

@YuvHayun YuvHayun merged commit f2e54dd into demisto:contrib/mohlcyber_contrib-mohlcyber-MISP Feb 15, 2024
19 of 23 checks passed
@content-bot content-bot mentioned this pull request Feb 15, 2024
Merged
5 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

dantavori added a commit that referenced this pull request Feb 18, 2024
@content-bot @mohlcyber
@YuvHayun @dantavori
MISP 2.1.41 - Add Custom Object command (#32955)
ef002a1 
* MISP 2.1.41 - Add Custom Object command (#32881)

* MISP 2.1.41 - add-custom-object command

* Updated release notes

* Updated MISPV3_test.py

* Update Packs/MISP/ReleaseNotes/2_1_41.md

Co-authored-by: Yuval Hayun <[email protected]>

* Updated MISPV3.py

* Revert Docker Version

---------

Co-authored-by: Yuval Hayun <[email protected]>

* Update Packs/MISP/ReleaseNotes/2_1_41.md

Co-authored-by: Dan Tavori <[email protected]>

---------

Co-authored-by: Martin Ohl <[email protected]>
Co-authored-by: Yuval Hayun <[email protected]>
Co-authored-by: Dan Tavori <[email protected]>
maimorag pushed a commit that referenced this pull request Feb 22, 2024
@content-bot @mohlcyber
@YuvHayun @dantavori @maimorag
MISP 2.1.41 - Add Custom Object command (#32955)
53c5ecb 
* MISP 2.1.41 - Add Custom Object command (#32881)

* MISP 2.1.41 - add-custom-object command

* Updated release notes

* Updated MISPV3_test.py

* Update Packs/MISP/ReleaseNotes/2_1_41.md

Co-authored-by: Yuval Hayun <[email protected]>

* Updated MISPV3.py

* Revert Docker Version

---------

Co-authored-by: Yuval Hayun <[email protected]>

* Update Packs/MISP/ReleaseNotes/2_1_41.md

Co-authored-by: Dan Tavori <[email protected]>

---------

Co-authored-by: Martin Ohl <[email protected]>
Co-authored-by: Yuval Hayun <[email protected]>
Co-authored-by: Dan Tavori <[email protected]>
@mohlcyber mohlcyber deleted the contrib-mohlcyber-MISP branch February 26, 2024 16:27
maimorag pushed a commit that referenced this pull request Feb 28, 2024
@content-bot @mohlcyber
@YuvHayun @dantavori @maimorag
MISP 2.1.41 - Add Custom Object command (#32955)
1632964 
* MISP 2.1.41 - Add Custom Object command (#32881)

* MISP 2.1.41 - add-custom-object command

* Updated release notes

* Updated MISPV3_test.py

* Update Packs/MISP/ReleaseNotes/2_1_41.md

Co-authored-by: Yuval Hayun <[email protected]>

* Updated MISPV3.py

* Revert Docker Version

---------

Co-authored-by: Yuval Hayun <[email protected]>

* Update Packs/MISP/ReleaseNotes/2_1_41.md

Co-authored-by: Dan Tavori <[email protected]>

---------

Co-authored-by: Martin Ohl <[email protected]>
Co-authored-by: Yuval Hayun <[email protected]>
Co-authored-by: Dan Tavori <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuvHayun YuvHayun YuvHayun approved these changes

@MLainer1 MLainer1 Awaiting requested review from MLainer1

Assignees

@YuvHayun YuvHayun

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. TIM Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohlcyber @content-bot @YuvHayun