Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trend micro vision one #32563

Merged
merged 63 commits into from
Mar 6, 2024
Merged

Trend micro vision one #32563

merged 63 commits into from
Mar 6, 2024

Conversation

shaqnawe
Copy link
Contributor

@shaqnawe shaqnawe commented Jan 31, 2024 •
edited
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Updated incoming mapper attributes. Updated pytmv1 package to 0.8.0 to support 6 new custom script actions. Fixed an issue with endpoint and email activity data count actions, where query_op was not being parsed correctly. This integration will use the dockerfiles docker image here: updated pytmv1 to 0.8.0 #23882

Must have

  • Tests
  • Documentation

shaqnawe added 24 commits January 18, 2024 17:30
@shaqnawe
updated integration and added 6 custom script actions and updated inc…
934a25a 
…oming mapper, yml and README.md.
@shaqnawe
added test data for custom script actions.
261eaec
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
9c3869a
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
137eb7e
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
7185cfd
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
1007b7f
@shaqnawe
updated actions per pytmv1 0.8.0
a79746e
@shaqnawe
updated yml and README.md
476e0df
@shaqnawe
fixed type in README.md description.
73cf0fb
@shaqnawe
updated unit tests.
591495d
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
d080d98
@shaqnawe
updated response attributes for download, update and delete custom sc…
de7529e 
…ript. Updated test data and formatted YML.
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
8aaf9c1
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
6bddb76
@shaqnawe
fixed mypy error in download_custom_script action.
f2addc3
@shaqnawe
updated reference for status in delete and update custom script actions.
f25e3f6
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
8d7e691
@shaqnawe
updated link to support sandbox analysis file types.
af29e3e
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
ae8c7eb
@shaqnawe
updated docker image to updated pytmv1 package 0.8.0
6a45fb7
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
73ff93b
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
9b4efa9
@shaqnawe
Merge branch 'demisto:master' into TrendMicroVisionOne
8c6616d
@shaqnawe
added dockerimage devdemisto/trend-pytmv1:0.8.0.86567 in yml.
d5adae0
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Jan 31, 2024
@content-bot content-bot changed the base branch from master to contrib/shaqnawe_TrendMicroVisionOne January 31, 2024 22:33
YuvHayun
YuvHayun requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shaqnawe, I have left some comments about things missing from our post demo discussion, let me know what have you decided about it.
No problem about the polling, you can keep it that way.

Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml Show resolved Hide resolved
Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.py
:rtype: ``dict`
"""
# Required Params
block_objects = safe_load_json(args[BLOCK_OBJECTS])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you decided to skip the block builder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipping the block builder to keep it uniform with other actions likes enable/disable account etc.

@YuvHayun
Copy link
Contributor

Also, a fix to the validate issue you have aws merge, please pull from master.

@shaqnawe
Copy link
Contributor Author

@YuvHayun I have update the integration description to make it shorter.

@YuvHayun YuvHayun added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 29, 2024
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/858283

@shaqnawe
Copy link
Contributor Author

@YuvHayun can we please hold the merge. There's an update for pytmv1 package to address an API issue. I'm working on updating demisto-docker image and will update the dockerimage in yml ASAP. Thank you

@shaqnawe shaqnawe mentioned this pull request Feb 29, 2024
Merged
@shaqnawe
Copy link
Contributor Author

shaqnawe commented Feb 29, 2024 •
edited
Loading

Created dockerfiles PR in relation to new pytmv1 package update. demisto/dockerfiles#24687
dockerimage needs to be updated to latest 0.8.2 when available in dockerhub/demisto.

@shaqnawe
Copy link
Contributor Author

shaqnawe commented Mar 1, 2024 •
edited
Loading

Updated get-custom-script-list action to include predefined option of bash or powershell for filetype and the block is built in the code logic.

@YuvHayun
Copy link
Contributor

YuvHayun commented Mar 5, 2024

Hey @shaqnawe, the docker pr was merged.
Please make sure to pull from master, update docker, and make sure that all steps passed so I can merge the pr.

@shaqnawe
Copy link
Contributor Author

shaqnawe commented Mar 5, 2024

Docker image has been updated to demisto/pytmv1:0.8.2.89444.

@shaqnawe
Copy link
Contributor Author

shaqnawe commented Mar 5, 2024

@YuvHayun No more changes to make, ready for merge.

@YuvHayun
Copy link
Contributor

YuvHayun commented Mar 6, 2024

Great job, thx a lot for your contribution, merging to internal pr.

@YuvHayun YuvHayun merged commit 8d5dabe into demisto:contrib/shaqnawe_TrendMicroVisionOne Mar 6, 2024
23 of 24 checks passed
@content-bot content-bot mentioned this pull request Mar 6, 2024
Merged
5 tasks
YuvHayun added a commit that referenced this pull request Mar 6, 2024
@content-bot @shaqnawe @YuvHayun
Trend micro vision one (#32563) (#33238)
1c77220 
* updated integration and added 6 custom script actions and updated incoming mapper, yml and README.md.

* added test data for custom script actions.

* updated actions per pytmv1 0.8.0

* updated yml and README.md

* fixed type in README.md description.

* updated unit tests.

* updated response attributes for download, update and delete custom script. Updated test data and formatted YML.

* fixed mypy error in download_custom_script action.

* updated reference for status in delete and update custom script actions.

* updated link to support sandbox analysis file types.

* updated docker image to updated pytmv1 package 0.8.0

* added dockerimage devdemisto/trend-pytmv1:0.8.0.86567 in yml.

* Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml



* Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml



* Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml



* added recommended changes.

* updated README.md with cortex convention for action names.

* updated dockerimage to demisto/pytmv1:0.8.0.87051

* added given-when-then docs for custom script actions and updated yml,README.md, and release notes.

* reverted param name to endpoint in get_endpoint_info to avoid breaking changes.

* added ip to secrets ignore.

* fixed secrets format

* updated add_note, update_status, get_endpoint and get_email activity data actions.

* updated docker image to demisto/pytmv1:0.8.1.88013

* Update Packs/TrendMicroVisionOne/ReleaseNotes/4_1_0.md

Updated release notes per YuvHayun's suggestion.



* updated record.json() to model_dump_json in fetch_incidents per update in BaseModel class.

* updated descriptions for required arguments for get-endpoint-info in README.md and yml

* updated argument description for endpoint-info,endpoint and email-activity-data,endpoint and email-activity-data-count and get-custom-script

* updated error description for download,delete custom script actions and added predefined value for query_op in get_custom_script_list.

* added list options for filetype and shortened description.

* added dropdown options for filetype in get custom script list as suggested.

* updated dockerimage to pytmv1:0.8.2.89444

* updated release notes to reflect correct dockerimage number.

---------

Co-authored-by: shaqnawe <[email protected]>
Co-authored-by: Yuval Hayun <[email protected]>
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
@content-bot @shaqnawe
@YuvHayun @pal-xmco
Trend micro vision one (demisto#32563) (demisto#33238)
f07a400 
* updated integration and added 6 custom script actions and updated incoming mapper, yml and README.md.

* added test data for custom script actions.

* updated actions per pytmv1 0.8.0

* updated yml and README.md

* fixed type in README.md description.

* updated unit tests.

* updated response attributes for download, update and delete custom script. Updated test data and formatted YML.

* fixed mypy error in download_custom_script action.

* updated reference for status in delete and update custom script actions.

* updated link to support sandbox analysis file types.

* updated docker image to updated pytmv1 package 0.8.0

* added dockerimage devdemisto/trend-pytmv1:0.8.0.86567 in yml.

* Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml



* Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml



* Update Packs/TrendMicroVisionOne/Integrations/TrendMicroVisionOneV3/TrendMicroVisionOneV3.yml



* added recommended changes.

* updated README.md with cortex convention for action names.

* updated dockerimage to demisto/pytmv1:0.8.0.87051

* added given-when-then docs for custom script actions and updated yml,README.md, and release notes.

* reverted param name to endpoint in get_endpoint_info to avoid breaking changes.

* added ip to secrets ignore.

* fixed secrets format

* updated add_note, update_status, get_endpoint and get_email activity data actions.

* updated docker image to demisto/pytmv1:0.8.1.88013

* Update Packs/TrendMicroVisionOne/ReleaseNotes/4_1_0.md

Updated release notes per YuvHayun's suggestion.



* updated record.json() to model_dump_json in fetch_incidents per update in BaseModel class.

* updated descriptions for required arguments for get-endpoint-info in README.md and yml

* updated argument description for endpoint-info,endpoint and email-activity-data,endpoint and email-activity-data-count and get-custom-script

* updated error description for download,delete custom script actions and added predefined value for query_op in get_custom_script_list.

* added list options for filetype and shortened description.

* added dropdown options for filetype in get custom script list as suggested.

* updated dockerimage to pytmv1:0.8.2.89444

* updated release notes to reflect correct dockerimage number.

---------

Co-authored-by: shaqnawe <[email protected]>
Co-authored-by: Yuval Hayun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuvHayun YuvHayun YuvHayun requested changes

@melamedbn melamedbn melamedbn approved these changes

@jlevypaloalto jlevypaloalto Awaiting requested review from jlevypaloalto

@thefrieddan1 thefrieddan1 Awaiting requested review from thefrieddan1

@michal-dagan michal-dagan Awaiting requested review from michal-dagan

@MLainer1 MLainer1 Awaiting requested review from MLainer1

@Ni-Knight Ni-Knight Awaiting requested review from Ni-Knight

Assignees

@melamedbn melamedbn

@YuvHayun YuvHayun

@kgal-pan kgal-pan

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shaqnawe @content-bot @melamedbn @YuvHayun @CLAassistant @kgal-pan