[Event Collector] - GitGuaridan #32039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantavori
reviewed
Jan 11, 2024
Packs/GitGuardian/Integrations/GitGuardianEventCollector/README.md
Outdated
Show resolved
Hide resolved
Packs/GitGuardian/Integrations/GitGuardianEventCollector/GitGuardianEventCollector.py
Show resolved
Hide resolved
dantavori
reviewed
Mar 3, 2024
Packs/GitGuardian/Integrations/GitGuardianEventCollector/GitGuardianEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/GitGuardian/Integrations/GitGuardianEventCollector/GitGuardianEventCollector.py
Outdated
Show resolved
Hide resolved
| For this HelloWorld implementation, no special attributes defined | ||
| """ | ||
|
|
||
| def search_events( |
There was a problem hiding this comment.
I'd merge this function with fetch_events()
There was a problem hiding this comment.
I prefer to keep them as separate functions
Packs/GitGuardian/Integrations/GitGuardianEventCollector/GitGuardianEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/GitGuardian/Integrations/GitGuardianEventCollector/GitGuardianEventCollector.py
Show resolved
Hide resolved
Packs/GitGuardian/Integrations/GitGuardianEventCollector/GitGuardianEventCollector.py
Outdated
Show resolved
Hide resolved
| params=params, | ||
| retries=3, | ||
| ) | ||
| new_events = self.remove_duplicated_events(response.get("results"), prev_run_fetched_event_ids) |
There was a problem hiding this comment.
why would we run this on the same prev_run_fetched_event_ids over multiple pages?
There was a problem hiding this comment.
The API returns results consequently in the incident ID, and not in the last_occurence_date field, which means that if event 1 happened after event number 2, they will still get returned as [event 1, event 2]
Packs/GitGuardian/Integrations/GitGuardianEventCollector/GitGuardianEventCollector_test.py
Outdated
Show resolved
Hide resolved
dantavori
approved these changes
Mar 3, 2024
Packs/GitGuardian/Integrations/GitGuardianEventCollector/GitGuardianEventCollector.yml
Outdated
Show resolved
Hide resolved
.../GitGuardian/Integrations/GitGuardianEventCollector/GitGuardianEventCollector_description.md
Outdated
Show resolved
Hide resolved
.../GitGuardian/Integrations/GitGuardianEventCollector/GitGuardianEventCollector_description.md
Outdated
Show resolved
Hide resolved
|
@MLainer1 Need content for the pack readme. |
Co-authored-by: ShirleyDenkberg <[email protected]>
pal-xmco
pushed a commit
to pal-xmco/content
that referenced
this pull request
Jun 19, 2024
* [Collector] - GitGuaridan * formast and docs * pack ignore * adding increment time to audit logs * added tests * DI * format * description * Adding modeling rules * Modified the modeling rule * Modified modeling rule * added support for incident type event * fix tests * added tests * pre-commit * Added url field to schema * readme * fetch redesign * precommit * line too long * changes * additionalinfo * cr * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <[email protected]> * flake8 * updated next run * autopep8 * changes --------- Co-authored-by: Yehonatan Asta <[email protected]> Co-authored-by: yasta5 <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Creating a new event collector for GitGuardian
Must have