refactor: Eliminate remaining repeat_vars() calls (#6359) #6375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
commented
Dec 31, 2024
iequidoo
force-pushed
the
iequidoo/drop-repeat_vars
branch
from
92adf14 to
50ad130
Compare
link2xt
reviewed
Jan 9, 2025
src/receive_imf.rs
Outdated
| ) STRICT", | ||
| (), | ||
| )?; | ||
| let mut stmt = t.prepare("INSERT INTO contacts_tmp(id) VALUES (?)")?; |
There was a problem hiding this comment.
Probably better specify it as temp.contacts_tmp to make sure this is not accidentally using a table with the same name from the real database.
There was a problem hiding this comment.
Renamed to temp.contacts, should be sufficient.
iequidoo
force-pushed
the
iequidoo/drop-repeat_vars
branch
from
50ad130 to
2eaf3cc
Compare
link2xt
approved these changes
Jan 14, 2025
Using `repeat_vars()` to generate SQL statements led to some of them having more than `SQLITE_MAX_VARIABLE_NUMBER` parameters and thus failing, so let's get rid of this pattern. But let's not optimise for now and just repeat executing an SQL statement in a loop, all the places where `repeat_vars()` is used seem not performance-critical and containing functions execute other SQL statements in loops. If needed, performance can be improved by preparing a statement and executing it in a loop. An exception is `lookup_chat_or_create_adhoc_group()` where `repeat_vars()` can't be replaced with a query loop, there we need to replace the `SELECT` query with a read transaction creating a temporary table which is used to perform the SELECT query then.
iequidoo
force-pushed
the
iequidoo/drop-repeat_vars
branch
from
2eaf3cc to
ecc93d9
Compare
iequidoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6359