fix: mark holiday notice messages as bot-generated #6374
Merged
+39
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/msg-is_bot
branch
from
dd2d569 to
58b14ed
Compare
link2xt
force-pushed
the
link2xt/msg-is_bot
branch
from
58b14ed to
4ce1dd1
Compare
iequidoo
approved these changes
Dec 29, 2024
| == Some(&"auto-generated".to_string()) | ||
| && parser.headers.contains_key("chat-version"); | ||
| let is_bot = | ||
| parser.headers.get("auto-submitted") == Some(&"auto-generated".to_string()); |
There was a problem hiding this comment.
.as_deref() probably can be used for the lhs to avoid to_string()
There was a problem hiding this comment.
I tried and this does not work because of the cursed &String type inside the return type of get. as_deref() changes nothing, it is still Option<&String> afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6373