refactor: add emit_msgs_changed_without_msg_id
#6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
reviewed
Dec 28, 2024
src/chat.rs
Outdated
| @@ -3319,6 +3318,8 @@ pub(crate) async fn mark_old_messages_as_noticed( | |||
| context: &Context, | |||
| mut msgs: Vec<ReceivedMsg>, | |||
| ) -> Result<()> { | |||
| debug_assert!(!msgs.is_empty()); | |||
There was a problem hiding this comment.
Why? It's a no-op if msgs is empty, moreover, fetch_new_messages() calls this function unconditionally
There was a problem hiding this comment.
Removed it. It broke all CI indeed.
link2xt
force-pushed
the
link2xt/emit_msgs_changed_without_msg_id
branch
from
5b56137 to
f05814d
Compare
Added debug assertions to make sure MsgsChanged is not emitted with 0 IDs by accident.
link2xt
force-pushed
the
link2xt/emit_msgs_changed_without_msg_id
branch
from
f05814d to
8a6e35e
Compare
iequidoo
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added debug assertions to make sure
MsgsChanged is not emitted with 0 IDs by accident.