-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] File deduplication #6332
Open
Hocuri
wants to merge
22
commits into
main
Choose a base branch
from
hoc/file-deduplication
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] File deduplication #6332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hocuri
force-pushed
the
hoc/file-deduplication
branch
from
December 12, 2024 21:57
abbaa2e
to
3cb9a66
Compare
6 tasks
I'm not sure whether we still need it and the tests pass without it, but also I don't want to introduce a new bug by changing stuff, and it's just 8 lines, anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of deduplicating by default, this adds a new function
set_file_and_deduplicate()
. When receiving messages, blobs will be deduplicated by default already.This is for #6265; read the issue description there for more details.
TODO:
accounts/2ff9fc096d2f46b6832b24a1ed99c0d6/dc.db-blobs
(53 chars), plus 64 chars for the filename would be 117).For later PRs:
BlobObject::create(…)
withBlobObject::create_and_deduplicate(…)
in order to deduplicate everytime core creates a fileFootnotes
Calculated with both https://printfn.github.io/fend/ and https://www.geogebra.org/calculator, both of which came to the same result (1,
2) ↩