-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FMA Portal changes for names, VPs and compliance filtering #45
Open
nklomp
wants to merge
38
commits into
deltaDAO:development
Choose a base branch
from
Sphereon-Opensource:development
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h results in the Federated Catalog Added SD compliance filter;
…h results in the Federated Catalog - Refactored of the filter; - Added button to UI;
- Added author/owner switch at asset list level; - Added author/owner switch at asset level;
…ature/FMA-25/query_filter
…ature/FMA-26/owner_author_switch
…h results in the Federated Catalog - Changed the filter button text;
- Added ellipsis to the name if greater than 25 chars;
…tal-rws into feature/FMA-26/owner_author_switch
- Fixed docker image issues; - Created deployment configuration;
- Changed isInCompliance to compliance.gx;
- Changed undefined to verifiedServiceProviderName;
- Fixed the total amount issue; - Added maxLength to nameTruncate function; - Changed raw to rawSD in verifySelfDescription function;
…portal - Added support for vps;
…portal - Added support for vps;
…portal - Fixed compliance.gx undefined;
…itch' into feature/Sphereon_changes # Conflicts: # app.config.js
…orrect URLs used to access acquarius and CS. Added name resolution for non GX datasets, adding (unverified)
…portal - Fixed infinite loop in publish page; - Fixed the provider service request; - Fixed undefined when checking whether the vp is compliant;
…-rws into feature/FMA-47/vp-support # Conflicts: # app.config.js # k8s/gx-portal-deployment.yaml # src/components/molecules/AssetTeaser.tsx # src/components/molecules/FormFields/ServiceSelfDescription.tsx # src/utils/metadata.ts # src/utils/subgraph.ts
…portal - Changed image version;
…portal - Fixed the bug handling Vps during SO creation;
…portal - Fixed the bug filtering compliant VPs in profile;
…portal - Updated deployment;
…portal - Updated deployment;
…portal - Fixed bug with compliance verification of raw sd;
…portal - Fixed the label issue;
…portal - Added configuration of multiple wallets; - Fixed the profile filter; - Fixed label problems;
…portal - Refactored legal name retrieval code;
- Moved the Self-Description to the bottom of the page; - Made the Self-Description expandable;
- Added the legal name to the profile page; - Made the show always show up instead of eth address;
- Added the legal name to the profile page; - Made the show always show up instead of eth address;
…portal - Removed Kubernetes deployment files;
Feature/fma 47/vp support
Feature/fma 69/UI improvements
✅ Deploy Preview for portal-rws-deltadao ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, these are the changes we made to the portal. To add the organizational name functionality, Verifiable Presentation support, and GX compliant filtering.
Below a summary of the main changes:
SD Support:
SDs are verified in the raw format only. If an URL is passed in, the SD is fetched and then verified
/src/utils/metadata.ts lines 154 - 159
/src/utils/metadata.ts lines 171 - 178
SDs as VPs and json object containing the credentials are supported
/src/utils/metadata.ts lines 180 - 189
VPs are already signed and won't get signed again. If the input is the original SD structure the flow remains untouched
/src/components/molecules/FormFields/ServiceSelfDescription.tsx lines 43 - 57
Compliance filter:
A variable was added to additionalInformation in metadata to store the results of the SD verification, so we are be able to filter the compliant SDs without verifying the whole list when accessing the catalogue
Asset
This variable was added:
Due to the changes below,
transformPublishFormToMetadata
andtransformPublishAlgorithmFormToMetadata
are now async and the code where the methods are called was updated as well/src/utils/metadata.ts lines 345 - 350 and 473 - 478
/src/components/Page/Publish/index.tsx line 167
/src/components/Page/Publish/index.tsx line 118
/src/components/organisms/AssetActions/Edit/DebugEditMetadata.tsx lines 16 - 27
/src/components/pages/Publish/Debug.tsx lines 14 -34
Legal Name:
We are using the legal name (comes from the VP) instead of the eth addresses in the catalogue and profile;
/src/utils/metadata.ts lines 485 - 497
/src/components/organisms/AssetContent/MetaFull.tsx lines 22 - 29
/src/components/organisms/AssetContent/MetaMain.tsx lines 66 - 73
/src/components/molecules/AssetTeaser.tsx lines 50 -57
/src/components/pages/Profile/Header/Account.tsx lines 19 - 26