Merged master #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note I did manually run the trim headers functional test successfully on this commit, since it touched some of trim headers code.
Commented out the change to the psbt test with a FIXME, due to differences between PSBT/PSET
Some refactoring around the pegged asset name during this merge, please check in the GUI.
…ders_sync was unused
delta1
commented
Dec 12, 2024
| BITCOIN_DAEMON_NAME=elementsd | ||
| BITCOIN_GUI_NAME=elements-qt | ||
| BITCOIN_TEST_NAME=test_bitcoin |
…t-liquidv1 Master discountct liquidv1
fix for intermittent assertion error in getselectionwaste introduced in f46275d as part of merge for bitcoin/bitcoin#25647 the assertion would trigger in a fundrawtransaction call in feature_confidential_transactions.py where the transaction inputs included a non-policy asset. during the loop in getselectionwaste, if the non-policy input waste was calculated first the assertion would be triggered because selected_effective_value has not yet met the selection target, because non-policy coins have 0 effective value the fix changed the assertion to an if statement, only adding to the waste metric when selected_effective_value meets the target.
FIXME investigate why this call to `send` would sometimes result in a "not BIP 125 replaceable" transaction
delta1
force-pushed
the
merged-master
branch
4 times, most recently
from
4cfc67a to
b706b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.