build for oem partners #735
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,12 +41,14 @@ | |||
| comment: Delphix User | |||
| home: /export/home/delphix | |||
| password: | |||
| "{{ lookup('env', 'APPLIANCE_PASSWORD') | password_hash('sha512') }}" | |||
| "$6$oSDBhe8aMbPzcuGf$Zpnq.v8h6hdq/eYXs61oxvCK/b08mx.5uD61xoJq8SrQS\ | |||
There was a problem hiding this comment.
do we really want to make these public? they are now...
should we create a new environment variable instead? e.g. APPLIANCE_PARTNER_PASSWORD?
There was a problem hiding this comment.
I do not intent to merge this PR. This is just a special build that won't ever make it into our repo.
There was a problem hiding this comment.
I don't see the need to change this line of code at all, actually. If our goal is to do a single manual build, we can set APPLIANCE_PASSWORD to whatever we want in the environment of that build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft for an external build we intend to share with our partners. This is just a draft PR since we're only doing the review to ensure that the build is safe to distribute.