Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end evaluation demo #32

Merged
merged 38 commits into from
Feb 27, 2024
Merged

End-to-end evaluation demo #32

merged 38 commits into from
Feb 27, 2024

Conversation

jaidhyani
Copy link
Collaborator

WIP

@jaidhyani jaidhyani linked an issue Feb 14, 2024 that may be closed by this pull request
@jaidhyani
Copy link
Collaborator Author

image

@jaidhyani jaidhyani force-pushed the 13-first-end2end-eval-demo branch 2 times, most recently from addecee to 47baf30 Compare February 15, 2024 00:05
@jaidhyani jaidhyani force-pushed the 13-first-end2end-eval-demo branch 2 times, most recently from 9b28687 to bfb67da Compare February 23, 2024 10:36
@jaidhyani
Copy link
Collaborator Author

image

@jaidhyani jaidhyani marked this pull request as ready for review February 23, 2024 12:51
@jaidhyani
Copy link
Collaborator Author

This ended up being an embarrassing quantity of iteration and written-then-deleted code for what was ultimately a pretty small PR. On the upside, I feel like I gained a better understanding of a lot of the codebase in the process.

data/README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, now that the static dir PR is in

scripts/map_tokens.py Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed and added to static

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed and added to static

@jaidhyani jaidhyani force-pushed the 13-first-end2end-eval-demo branch from 5a2c6af to ff64510 Compare February 23, 2024 17:33
@menamerai menamerai self-requested a review February 23, 2024 18:18

def load_logprob_datasets(split: str = "validation") -> dict[str, list[list[float]]]:
return {
model: cast(dict, load_logprob_dataset(model)[split])["logprobs"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried how much we have to use casting with Dataset objects :/

Copy link
Collaborator Author

@jaidhyani jaidhyani Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the dataset library clearly wasn't designed with type-guarantees in mind. Building a library of functions that take care of the casting and other stuff we don't want to worry about in our day-to-day might be a good idea. Ticket would be something like "identify repetitive casts in the codebase and replace them with library functions".

data/README.md Outdated Show resolved Hide resolved
protobuf==4.25.2
plotly==5.18.0
spacy-transformers==1.3.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to reply to this but the vscode inline thingy is kind of buggy and it ended up as a separate comment. Anyway:

spacy-transformers is a dependency I needed to get the token labeling code to work that I think just got missed by accident earlier (it's a hidden dependency that only shows up at runtime).

Copy link
Contributor

@jettjaniak jettjaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. Left a few comments, use your best judgement to decide what to address and what to ignore for now

Copy link
Collaborator Author

@jaidhyani jaidhyani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

spacy-transformers is a dependency I needed to get the token labeling code to work that I think just got missed by accident earlier (it's a hidden dependency that only shows up at runtime).

@jaidhyani jaidhyani merged commit a48370b into main Feb 27, 2024
1 check passed
@jaidhyani jaidhyani deleted the 13-first-end2end-eval-demo branch February 27, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

first end2end eval demo
3 participants