Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode now uses black from venv instead of bringing its own and causing conflicts #28

Merged
merged 1 commit into from
Feb 13, 2024
Merged

vscode now uses black from venv instead of bringing its own and causing conflicts #28

merged 1 commit into from
Feb 13, 2024

Conversation

jaidhyani
Copy link
Collaborator

No description provided.

@jaidhyani jaidhyani linked an issue Feb 11, 2024 that may be closed by this pull request
Fix black version conflicts #30
Closed
@jaidhyani jaidhyani requested a review from jettjaniak February 11, 2024 16:46
jettjaniak
jettjaniak approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@jettjaniak jettjaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I checked and the plugin page was saying it will use fromEnvironment as long as black is installed? Weird.

@jaidhyani
Copy link
Collaborator Author

I think I checked and the plugin page was saying it will use fromEnvironment as long as black is installed? Weird.

I'm betting I didn't have black installed in the default environment when I first installed the extension.

@jaidhyani jaidhyani merged commit 015aa68 into main Feb 13, 2024
1 check passed
@jaidhyani jaidhyani deleted the black_from_venv branch March 20, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jettjaniak jettjaniak jettjaniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix black version conflicts
2 participants
@jaidhyani @jettjaniak