Skip to content

Commit

Permalink
Set isort to use black profile to avoid formatting conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
Jai committed Feb 9, 2024
1 parent 7061586 commit 5ddbdb7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- main
pull_request:
branches:
- '*'
- "*"

permissions:
actions: write
Expand All @@ -29,6 +29,6 @@ jobs:
- name: black
run: black --check .
- name: isort
run: isort --check .
run: isort --profile black --check .
- name: pytest
run: pytest
run: pytest
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ repos:
rev: 5.13.2
hooks:
- id: isort
name: isort (python)
name: isort (python)
args: ["--profile", "black"]

2 comments on commit 5ddbdb7

@jettjaniak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also isort on file save in vscode

@jaidhyani
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also isort on file save in vscode

Oh yeah, I forgot that we can set vscode settings from the repo. Added: in cd6f9da

Please sign in to comment.