Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically detecting compiler & linker used by kernel #298

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Automatically detecting compiler & linker used by kernel #298

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4d904f
Automatically detecting CC & LD used by kernel
xuzhen Jan 24, 2023
111ae83
Fix test script for kernel compiled by clang
xuzhen Jan 24, 2023
0841cb0
Add clang test workflow
xuzhen Jan 25, 2023
7f44fd9
Fix printf errors caused by leading zeros
xuzhen Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dkms.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,11 +824,11 @@ detect_toolchain_version() {
# $4 = patch version, optional
local -a filenames
if [[ "$4" ]]; then
filenames+=( "$1-$(printf "%d.%d.%d" "$2" "$3" "$4")" )
filenames+=( "$1-$((10#$2)).$((10#$3)).$((10#$4))" )
fi
filenames+=(
"$1-$(printf "%d.%d" "$2" "$3")"
"$1-$(printf "%d" "$2")"
"$1-$((10#$2)).$((10#$3))"
"$1-$((10#$2))"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash this with the respective commit and add an inline comment or two.
Something like "Zero extend (or zero prefix perhaps?) the respective versions to avoid issues like XXX being detected as YYY"

"$1"
)
for f in "${filenames[@]}"; do
Expand Down