Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions #95

Merged
merged 2 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 3 additions & 43 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,11 @@
name: Workflow
on:
on: # yamllint disable-line rule:truthy
push:
branches: [main]
pull_request:
branches: [main]
jobs:
code-check:
name: Check Go formatting, linting, vetting
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v4
- name: Run the formatter, linter, and vetter
uses: dell/common-github-actions/go-code-formatter-linter-vetter@main
with:
directories: ./...

sanitize:
name: Check for forbidden words
runs-on: ubuntu-latest
Expand All @@ -25,38 +16,7 @@ jobs:
uses: dell/common-github-actions/code-sanitizer@main
with:
args: /github/workspace
test:
name: Run Go unit tests and check package coverage
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v4
- name: Run unit tests and check package coverage
uses: dell/common-github-actions/go-code-tester@main
with:
threshold: 90
go_security_scan:
name: Go security
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v4
- name: Run Go Security
uses: securego/gosec@master
with:
# exclude "G108: Profiling endpoint is automatically exposed" because we are exposing on an internal port
args: -exclude=G108 ./...
malware_security_scan:
name: Malware Scanner
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v4
- name: Run malware scan
uses: dell/common-github-actions/malware-scanner@main
with:
directories: .
options: -ri

image_security_scan:
name: Image Scanner
runs-on: ubuntu-latest
Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/common-workflows.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Common Workflows
on: # yamllint disable-line rule:truthy
push:
branches: [main]
pull_request:
branches: ["**"]

jobs:

# golang static analysis checks
go-static-analysis:
uses: dell/common-github-actions/.github/workflows/go-static-analysis.yaml@main
name: Golang Validation

common:
name: Quality Checks
uses: dell/common-github-actions/.github/workflows/go-common.yml@main
2 changes: 1 addition & 1 deletion .github/workflows/go-version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# Reusable workflow to perform go version update on Golang based projects
name: Go Version Update

on:
on: # yamllint disable-line rule:truthy
workflow_dispatch:
repository_dispatch:
types: [go-update-workflow]
Expand Down
30 changes: 0 additions & 30 deletions .github/workflows/linters.yaml

This file was deleted.

30 changes: 0 additions & 30 deletions .golangci.yaml

This file was deleted.

1 change: 0 additions & 1 deletion internal/common/testdata/invalid-format.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
invalid_format

1 change: 0 additions & 1 deletion internal/common/testdata/no-global-id.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ arrays:
isDefault: true
blockProtocol: "auto"
nasName: "nas-server"

1 change: 0 additions & 1 deletion internal/common/testdata/sample-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,3 @@ arrays:
password: "password"
skipCertificateValidation: true
blockProtocol: "FC"

Loading