Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pointing to latest gopowerstore commit #86

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

shefali-malhotra
Copy link
Contributor

Description

pointing to latest gopowerstore commit

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1443

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran Unit tests
    image

  • Verified e2e cases manually

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@csmbot
Copy link
Collaborator

csmbot commented Oct 12, 2024

Can one of the admins verify this patch?

nitesh3108
nitesh3108 previously approved these changes Oct 13, 2024
Copy link
Contributor

@chimanjain chimanjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shefali-malhotra shefali-malhotra merged commit f84ac07 into main Oct 14, 2024
7 checks passed
@shefali-malhotra shefali-malhotra deleted the update_gopowerstore branch October 14, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants