Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the go library #78

Merged
merged 2 commits into from
May 28, 2024
Merged

Updated the go library #78

merged 2 commits into from
May 28, 2024

Conversation

HarishH-DELL
Copy link
Contributor

Description

Updated the Go Library

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1280

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@chimanjain
Copy link
Contributor

Can you run go mod tidy, the go.sum file is not updated

@csmbot
Copy link
Collaborator

csmbot commented May 28, 2024

Can one of the admins verify this patch?

@rajendraindukuri rajendraindukuri merged commit a0a397c into release-v1.8.1 May 28, 2024
1 check passed
@chimanjain chimanjain deleted the go-release branch May 28, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@chimanjain chimanjain chimanjain approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1 anandrajak1 is a code owner

@bjiang27 bjiang27 Awaiting requested review from bjiang27 bjiang27 is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HarishH-DELL @chimanjain @csmbot @rajendraindukuri @nitesh3108 @shefali-malhotra