Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade goclient library and fix linting #73

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

alikdell
Copy link
Contributor

@alikdell alikdell commented Mar 1, 2024

Description

Upgrade goclient library and fix linting.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#dell/csm#1098

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@csmbot
Copy link
Collaborator

csmbot commented Mar 1, 2024

Can one of the admins verify this patch?

@dell dell deleted a comment from atye Mar 1, 2024
@alikdell
Copy link
Contributor Author

alikdell commented Mar 1, 2024

e2e pass

@donatwork
Copy link
Contributor

e2e pass

@alikdell alikdell merged commit fea1118 into main Mar 1, 2024
8 checks passed
@alikdell alikdell deleted the upgrade-goclient branch March 1, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants