-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle segmentation violation #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitesh3108
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
EvgenyUglov,
bjiang27,
taohe1012,
P-Cao,
baoy1,
YianZong,
forrestxia,
donatwork,
harshaatdell and
anandrajak1
as code owners
November 28, 2023 18:36
Can one of the admins verify this patch? |
Looks like the unit tests is below 90% in one package. |
donatwork
approved these changes
Nov 29, 2023
Updated the metrics e2e and topology test cases screenshot |
skip e2e test |
e2e pass |
shefali-malhotra
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
skip e2e test |
e2e pass |
rajendraindukuri
approved these changes
Nov 29, 2023
skip e2e test |
shanmydell
approved these changes
Nov 29, 2023
e2e pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a nil check to skip processing pvs without ClaimRef. This will prevent karavi-metrics-powerscale from crashing when there are unbound pv s in clusters
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration