Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powerstore session #65

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Powerstore session #65

merged 4 commits into from
Nov 2, 2023

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Oct 28, 2023

Description

Update gopowerstore client to use the new session tokens in the client. This will reduce the number of sessions opened when the metrics collection runs.

I want to get this merged in now so we can do some more early testing in the pipelines before we finalize the goclient before release.

GitHub Issue #
dell/csm#1006

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Manual install and verification of metrics connections to the array.
  • [ ]

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@donatwork
Copy link
Contributor Author

run e2e test

@donatwork
Copy link
Contributor Author

run e2e tests

santhoshatdell
santhoshatdell previously approved these changes Nov 1, 2023
@donatwork
Copy link
Contributor Author

skip e2e test

@donatwork
Copy link
Contributor Author

e2e pass

Copy link

@anandrajak1 anandrajak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e pass

@donatwork donatwork merged commit cf59dfd into main Nov 2, 2023
8 checks passed
@donatwork donatwork deleted the powerstore-session branch November 2, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants