-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Powerstore session #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run e2e test |
run e2e tests |
donatwork
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
EvgenyUglov,
bjiang27,
taohe1012,
P-Cao,
baoy1,
YianZong,
forrestxia,
harshaatdell and
anandrajak1
as code owners
November 1, 2023 20:34
santhoshatdell
previously approved these changes
Nov 1, 2023
santhoshatdell
approved these changes
Nov 2, 2023
lukeatdell
approved these changes
Nov 2, 2023
anandrajak1
approved these changes
Nov 2, 2023
skip e2e test |
e2e pass |
anandrajak1
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update gopowerstore client to use the new session tokens in the client. This will reduce the number of sessions opened when the metrics collection runs.
I want to get this merged in now so we can do some more early testing in the pipelines before we finalize the goclient before release.
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Manual inspection of the GUI
I have verified that the dashboards show the data properly while generating I/O and storage resources