Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go modules for CSM release 1.8 #56

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Update Go modules for CSM release 1.8 #56

merged 2 commits into from
Sep 6, 2023

Conversation

donatwork
Copy link
Contributor

Description

Update with released Go client modules.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#885

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Test B

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@donatwork donatwork marked this pull request as ready for review September 6, 2023 15:43
@anandrajak1
Copy link

run e2e test

3 similar comments
@anandrajak1
Copy link

run e2e test

@anandrajak1
Copy link

run e2e test

@anandrajak1
Copy link

run e2e test

@anandrajak1
Copy link

run e2e test

@anandrajak1
Copy link

e2e pass

@anandrajak1 anandrajak1 merged commit c51623a into main Sep 6, 2023
7 checks passed
@donatwork donatwork deleted the 885-mod-updates branch September 7, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshatdell santhoshatdell santhoshatdell approved these changes

@anandrajak1 anandrajak1 anandrajak1 approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

@bjiang27 bjiang27 Awaiting requested review from bjiang27 bjiang27 is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012

@P-Cao P-Cao Awaiting requested review from P-Cao

@baoy1 baoy1 Awaiting requested review from baoy1

@YianZong YianZong Awaiting requested review from YianZong

@forrestxia forrestxia Awaiting requested review from forrestxia

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donatwork @anandrajak1 @santhoshatdell