Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go modules #101

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Update go modules #101

merged 1 commit into from
Dec 2, 2024

Conversation

panigs7
Copy link
Contributor

@panigs7 panigs7 commented Nov 29, 2024

Description

Updated the direct dependencies in go modules according to PR #92. Otel updates are not taken up as the version update is bringing major changes to methods which is beyond the scope of this PR.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test passed
    image

@csmbot
Copy link
Collaborator

csmbot commented Nov 29, 2024

Can one of the admins verify this patch?

Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarishH-DELL HarishH-DELL merged commit f90283d into main Dec 2, 2024
8 checks passed
@HarishH-DELL HarishH-DELL deleted the update-go-modules branch December 2, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants