Skip to content

Commit

Permalink
Use common base image (#67)
Browse files Browse the repository at this point in the history
  • Loading branch information
tdawe authored Nov 8, 2023
1 parent cf59dfd commit 4c89bc3
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
4 changes: 3 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
FROM registry.access.redhat.com/ubi9/ubi-micro@sha256:630cf7bdef807f048cadfe7180d6c27eb3aaa99323ffc3628811da230ed3322a
ARG BASEIMAGE

FROM $BASEIMAGE as final
LABEL vendor="Dell Inc." \
name="csm-metrics-powerstore" \
summary="Dell Container Storage Modules (CSM) for Observability - Metrics for PowerStore" \
Expand Down
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ test:
go test -count=1 -cover -race -timeout 30s -short ./...

.PHONY: docker
docker:
SERVICE=cmd/metrics-powerstore docker build -t csm-metrics-powerstore -f Dockerfile cmd/metrics-powerstore/
docker: download-csm-common
$(eval include csm-common.mk)
SERVICE=cmd/metrics-powerstore docker build -t csm-metrics-powerstore -f Dockerfile --build-arg BASEIMAGE=$(DEFAULT_BASEIMAGE) cmd/metrics-powerstore/

.PHONY: push
push:
Expand All @@ -44,3 +45,7 @@ tag:
.PHONY: check
check:
./scripts/check.sh ./cmd/... ./opentelemetry/... ./internal/...

.PHONY: download-csm-common
download-csm-common:
curl -O -L https://raw.githubusercontent.com/dell/csm/main/config/csm-common.mk

0 comments on commit 4c89bc3

Please sign in to comment.