Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Multi stage build for sdk image. #40

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Implement Multi stage build for sdk image. #40

merged 3 commits into from
Jan 29, 2024

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Jan 11, 2024 •
edited
Loading

Description

Implement Multi stage build for sdk image.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1098

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

  • Docker image build
    Screenshot 2024-01-11 172105

  • Ran basic sanity test on built docker image.

@gallacher
Copy link
Collaborator

@chimanjain - are these changes required across other repositories to maintain consistency? Is there a GitHub issue these changes are associated with?

@chimanjain
Copy link
Contributor Author

@chimanjain - are these changes required across other repositories to maintain consistency? Is there a GitHub issue these changes are associated with?

Yes, these changes will made across all the metrics sdk images. GitHub issue has been created for these changes dell/csm#1098.

@nitesh3108
Copy link
Collaborator

e2e pass

@nitesh3108
Copy link
Collaborator

skip e2e

@rajendraindukuri
Copy link
Collaborator

e2e pass

@rajendraindukuri
Copy link
Collaborator

skip e2e

@donatwork
Copy link
Contributor

e2e pass

@donatwork
Copy link
Contributor

e2e pass

@donatwork
Copy link
Contributor

skip e2e tests

1 similar comment
@donatwork
Copy link
Contributor

skip e2e tests

@donatwork
Copy link
Contributor

e2e pass

@donatwork donatwork closed this Jan 29, 2024
@donatwork donatwork reopened this Jan 29, 2024
@donatwork
Copy link
Contributor

e2e pass

@donatwork
Copy link
Contributor

run e2e tests

@donatwork
Copy link
Contributor

e2e pass

@donatwork
Copy link
Contributor

skip e2e tests

@dell dell deleted a comment from csmbot Jan 29, 2024
@hoppea2 hoppea2 merged commit b84ed1a into main Jan 29, 2024
14 of 15 checks passed
@hoppea2 hoppea2 deleted the multi-stage-build branch January 29, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@gallacher gallacher gallacher approved these changes

@donatwork donatwork donatwork approved these changes

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1 anandrajak1 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chimanjain @gallacher @nitesh3108 @rajendraindukuri @donatwork @hoppea2