Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Codeowner #36

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Update Codeowner #36

merged 2 commits into from
Nov 2, 2023

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Oct 30, 2023 •
edited
Loading

Description

Update the codeowner list

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@csmbot
Copy link
Collaborator

csmbot commented Oct 30, 2023

Can one of the admins verify this patch?

donatwork
donatwork approved these changes Oct 30, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
HarishH-DELL
HarishH-DELL approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@donatwork
Copy link
Contributor

skip e2e test

@donatwork
Copy link
Contributor

e2e pass

@chimanjain chimanjain merged commit 23cd87c into main Nov 2, 2023
9 checks passed
@chimanjain chimanjain deleted the update-codeowner branch November 2, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@donatwork donatwork donatwork approved these changes

@forrestxia forrestxia Awaiting requested review from forrestxia

@YianZong YianZong Awaiting requested review from YianZong

@baoy1 baoy1 Awaiting requested review from baoy1

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1 anandrajak1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chimanjain @csmbot @donatwork @HarishH-DELL